Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug with deployment, log, and cr deletion #50

Merged
merged 4 commits into from
Feb 24, 2022

Conversation

medegw01
Copy link
Contributor

@medegw01 medegw01 commented Feb 24, 2022

Description

This PR:

  • updates sample files to point to the latest sidecar versions

GitHub Issues

List the GitHub issues impacted by this PR: N/A

GitHub Issue #
159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Manually run E2E Test

Operator deployment

# kubectl get pods -n dell-csm-operator
NAME                                                    READY   STATUS    RESTARTS   AGE
dell-csm-operator-controller-manager-5d6c4bfbdd-v4txk   2/2     Running   0          36m

Driver deployment

# kubectl get pods -n test-isilon
NAME                                      READY   STATUS    RESTARTS   AGE
test-isilon-controller-77d7d5c758-j5cmg   6/6     Running   0          4m51s
test-isilon-node-bwnfl                    3/3     Running   5          4m51s
test-isilon-node-d2mlh                    3/3     Running   6          4m51s

Revert Changes to file. Changes have been handled in another PR
abhi16394
abhi16394 previously approved these changes Feb 24, 2022
@medegw01 medegw01 merged commit 42819e9 into main Feb 24, 2022
@medegw01 medegw01 deleted the bugfix-driver-install branch February 24, 2022 18:53
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* Update csm_controller.go

Revert Changes to file. Changes have been handled in another PR

* rename json field to match the once used by driver

* fixes bug with deployment, log, and cr deletion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants