Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daemonset name mismatch for standalone app mobility install #457

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

jooseppi-luna
Copy link
Contributor

Description

When application-mobility was deployed standalone, the daemonset name was not what operator expected, and so the csm object would be marked as failed, even though the deployment had succeeded. This PR fixes that by rolling back in old code that we had to address this use case.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1133

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Successfully replicated the issue, then fixed it and confirmed the install was working afterward. Running e2e tests now and will pull this out of draft when they pass.

@jooseppi-luna
Copy link
Contributor Author

Pulling PR out of draft for approval, we will run E2E tests tomorrow once the license generation issues are fixed.

Copy link
Contributor

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for AM, is daemonset being checked twice?
IIRC Abhi's PR is also doing a daemon set check in his PR

@jooseppi-luna jooseppi-luna merged commit 7d71125 into release-v1.4.2 Feb 8, 2024
1 check failed
@jooseppi-luna
Copy link
Contributor Author

So for AM, is daemonset being checked twice? IIRC Abhi's PR is also doing a daemon set check in his PR

Hmm not sure if Abhi is checking the same thing but we can look into it before merging the changes into main

KerryKovacevic pushed a commit that referenced this pull request Feb 8, 2024
JacobGros added a commit that referenced this pull request Feb 19, 2024
* Add permissions for SC removal. (#431)

* Bump_up_csm-operator_version_to_1.4.1 (#434)

* Patch version support (#433)

* Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity

* Updating module config version for Pmax, Pscale, PFlex and unity

* Update storage_csm_powerflex.yaml

* version changed to 2.9.1

* version changed to 2.9.1

* Enabling github actions for all branch

* updated version to 2.9.1 for unity, powerflex, powerscale and powermax

* Adding the support of PStore v2.9.1

* Adding the support of PFlex v2.9.1

* Version bumpup replication 1.7.1

* Bump up version for authorization, resiliency

* update csi-metadata-retriever version to 1.6.1

* update reverseproxy version to 2.8.1

---------

Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>

* Change namespace name to match documentation. (#437)

* go-yaml version update (#438)

* go-yaml version update

* update go-yaml package to latest

* remove extra verbs

* remove duplicate verbs and add correct test files for resiliency UT

---------

Co-authored-by: Shayna Finocchiaro <[email protected]>

* [bug-1120]: Update Authorization sidecar to use insecure flag (#442)

* fix auth cert

* remove constant

* remove duplicate verbs

* reverting #426 changes (#444)

* Update final manifests for posting of Operator 1.4.1 (#445)

* KRV-20573/csm status (#446)

* add module status

* Adding CSM Module status

* Addressing the comments for PR

* Making code reusable

* Fix formatting issue

* Resolving gosec issue

* Final manifest update and apex client (#447)

* Add csm watch permissions. (#448)

* Merged CSM Module Status

* Fix App-Mob node error (#457)

Co-authored-by: abhi16394 <[email protected]>

* Bump up CSM Operator version to 1.4.2 (#458)

* update csm operator version to 1.4.2

* bump-up-op-version-1.4.2

* updated version in operator.yaml

* adding missing arg to fix e2e

* update authorization e2e (#459)

* skip cert validation in e2e (#460)

* Fixing FSGroupPolicy issue (#463)

* Fixing FSGroupPolicy issue

* Add unit test

---------

Co-authored-by: Akshay Saini <[email protected]>

* Fix for controller race, daemon status, and obs namespace  (#464)

* test controller state calc

* add debug logs

* check for driver

* add daemonnset update

* adds ns fix for when pod ns dis not csm ns

* add ns check for daemon and deployment as well

* fix typo

* fix typo

* explicitly return nil

* add missing replace statements

---------

Co-authored-by: grosnj1 <[email protected]>

* Auth proxy status fix (#465)

* actions

* working on auth proxy status check

* finished status check

* fix 1

* fix or

* code compiles

* keep auth proxy out of daemonset check

* trying to figure out deployment name

* formatting

* fix auth name in if condition

* no daemonset

* fix

* added log statements

* added another log statement

* fix log statement

* logs logs logs

* compile

* more logs

* add logs and try updating status from handlesuccess

* remove UpdateStatus call for now

* adding csm label to auth

* remove extraneous string replacement

* removing commented code

* Update actions.yml

* fix merge issue

* fix fmt

* fix pscale + obs issue  (#467)

* fix some issues

* fiix label issue, add debug logs

* add more debug

* more  debugg lines

* fix pscale issue

* remmove debug logs

* gofmt

* set available to 0 en deployment is not checked

* fix if check

---------

Co-authored-by: grosnj1 <[email protected]>

* update final manifests (#468)

* fix vetting issues (#477)

Co-authored-by: grosnj1 <[email protected]>

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>
@JacobGros JacobGros mentioned this pull request Feb 19, 2024
10 tasks
JacobGros added a commit that referenced this pull request Feb 20, 2024
* Verified merge fixed release v1.4.2 (#479)

* Add permissions for SC removal. (#431)

* Bump_up_csm-operator_version_to_1.4.1 (#434)

* Patch version support (#433)

* Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity

* Updating module config version for Pmax, Pscale, PFlex and unity

* Update storage_csm_powerflex.yaml

* version changed to 2.9.1

* version changed to 2.9.1

* Enabling github actions for all branch

* updated version to 2.9.1 for unity, powerflex, powerscale and powermax

* Adding the support of PStore v2.9.1

* Adding the support of PFlex v2.9.1

* Version bumpup replication 1.7.1

* Bump up version for authorization, resiliency

* update csi-metadata-retriever version to 1.6.1

* update reverseproxy version to 2.8.1

---------

Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>

* Change namespace name to match documentation. (#437)

* go-yaml version update (#438)

* go-yaml version update

* update go-yaml package to latest

* remove extra verbs

* remove duplicate verbs and add correct test files for resiliency UT

---------

Co-authored-by: Shayna Finocchiaro <[email protected]>

* [bug-1120]: Update Authorization sidecar to use insecure flag (#442)

* fix auth cert

* remove constant

* remove duplicate verbs

* reverting #426 changes (#444)

* Update final manifests for posting of Operator 1.4.1 (#445)

* KRV-20573/csm status (#446)

* add module status

* Adding CSM Module status

* Addressing the comments for PR

* Making code reusable

* Fix formatting issue

* Resolving gosec issue

* Final manifest update and apex client (#447)

* Add csm watch permissions. (#448)

* Merged CSM Module Status

* Fix App-Mob node error (#457)

Co-authored-by: abhi16394 <[email protected]>

* Bump up CSM Operator version to 1.4.2 (#458)

* update csm operator version to 1.4.2

* bump-up-op-version-1.4.2

* updated version in operator.yaml

* adding missing arg to fix e2e

* update authorization e2e (#459)

* skip cert validation in e2e (#460)

* Fixing FSGroupPolicy issue (#463)

* Fixing FSGroupPolicy issue

* Add unit test

---------

Co-authored-by: Akshay Saini <[email protected]>

* Fix for controller race, daemon status, and obs namespace  (#464)

* test controller state calc

* add debug logs

* check for driver

* add daemonnset update

* adds ns fix for when pod ns dis not csm ns

* add ns check for daemon and deployment as well

* fix typo

* fix typo

* explicitly return nil

* add missing replace statements

---------

Co-authored-by: grosnj1 <[email protected]>

* Auth proxy status fix (#465)

* actions

* working on auth proxy status check

* finished status check

* fix 1

* fix or

* code compiles

* keep auth proxy out of daemonset check

* trying to figure out deployment name

* formatting

* fix auth name in if condition

* no daemonset

* fix

* added log statements

* added another log statement

* fix log statement

* logs logs logs

* compile

* more logs

* add logs and try updating status from handlesuccess

* remove UpdateStatus call for now

* adding csm label to auth

* remove extraneous string replacement

* removing commented code

* Update actions.yml

* fix merge issue

* fix fmt

* fix pscale + obs issue  (#467)

* fix some issues

* fiix label issue, add debug logs

* add more debug

* more  debugg lines

* fix pscale issue

* remmove debug logs

* gofmt

* set available to 0 en deployment is not checked

* fix if check

---------

Co-authored-by: grosnj1 <[email protected]>

* update final manifests (#468)

* fix vetting issues (#477)

Co-authored-by: grosnj1 <[email protected]>

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>

* PR feedback

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>
@JacobGros JacobGros mentioned this pull request Feb 20, 2024
10 tasks
JacobGros added a commit that referenced this pull request Feb 20, 2024
* Test branch (#482)

* Verified merge fixed release v1.4.2 (#479)

* Add permissions for SC removal. (#431)

* Bump_up_csm-operator_version_to_1.4.1 (#434)

* Patch version support (#433)

* Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity

* Updating module config version for Pmax, Pscale, PFlex and unity

* Update storage_csm_powerflex.yaml

* version changed to 2.9.1

* version changed to 2.9.1

* Enabling github actions for all branch

* updated version to 2.9.1 for unity, powerflex, powerscale and powermax

* Adding the support of PStore v2.9.1

* Adding the support of PFlex v2.9.1

* Version bumpup replication 1.7.1

* Bump up version for authorization, resiliency

* update csi-metadata-retriever version to 1.6.1

* update reverseproxy version to 2.8.1

---------

Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>

* Change namespace name to match documentation. (#437)

* go-yaml version update (#438)

* go-yaml version update

* update go-yaml package to latest

* remove extra verbs

* remove duplicate verbs and add correct test files for resiliency UT

---------

Co-authored-by: Shayna Finocchiaro <[email protected]>

* [bug-1120]: Update Authorization sidecar to use insecure flag (#442)

* fix auth cert

* remove constant

* remove duplicate verbs

* reverting #426 changes (#444)

* Update final manifests for posting of Operator 1.4.1 (#445)

* KRV-20573/csm status (#446)

* add module status

* Adding CSM Module status

* Addressing the comments for PR

* Making code reusable

* Fix formatting issue

* Resolving gosec issue

* Final manifest update and apex client (#447)

* Add csm watch permissions. (#448)

* Merged CSM Module Status

* Fix App-Mob node error (#457)

Co-authored-by: abhi16394 <[email protected]>

* Bump up CSM Operator version to 1.4.2 (#458)

* update csm operator version to 1.4.2

* bump-up-op-version-1.4.2

* updated version in operator.yaml

* adding missing arg to fix e2e

* update authorization e2e (#459)

* skip cert validation in e2e (#460)

* Fixing FSGroupPolicy issue (#463)

* Fixing FSGroupPolicy issue

* Add unit test

---------

Co-authored-by: Akshay Saini <[email protected]>

* Fix for controller race, daemon status, and obs namespace  (#464)

* test controller state calc

* add debug logs

* check for driver

* add daemonnset update

* adds ns fix for when pod ns dis not csm ns

* add ns check for daemon and deployment as well

* fix typo

* fix typo

* explicitly return nil

* add missing replace statements

---------

Co-authored-by: grosnj1 <[email protected]>

* Auth proxy status fix (#465)

* actions

* working on auth proxy status check

* finished status check

* fix 1

* fix or

* code compiles

* keep auth proxy out of daemonset check

* trying to figure out deployment name

* formatting

* fix auth name in if condition

* no daemonset

* fix

* added log statements

* added another log statement

* fix log statement

* logs logs logs

* compile

* more logs

* add logs and try updating status from handlesuccess

* remove UpdateStatus call for now

* adding csm label to auth

* remove extraneous string replacement

* removing commented code

* Update actions.yml

* fix merge issue

* fix fmt

* fix pscale + obs issue  (#467)

* fix some issues

* fiix label issue, add debug logs

* add more debug

* more  debugg lines

* fix pscale issue

* remmove debug logs

* gofmt

* set available to 0 en deployment is not checked

* fix if check

---------

Co-authored-by: grosnj1 <[email protected]>

* update final manifests (#468)

* fix vetting issues (#477)

Co-authored-by: grosnj1 <[email protected]>

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>

* PR feedback

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>

* add KUBE_NODE_NAME back in

* add KUBE_NODE_NAME back in

* add KUBE_NODE_NAME back into tests

* Update dell-csm-operator.clusterserviceversion.yaml

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* Test branch (#482)

* Verified merge fixed release v1.4.2 (#479)

* Add permissions for SC removal. (#431)

* Bump_up_csm-operator_version_to_1.4.1 (#434)

* Patch version support (#433)

* Adding support of v2.9.1 for Pmax, Pscale, PFlex and unity

* Updating module config version for Pmax, Pscale, PFlex and unity

* Update storage_csm_powerflex.yaml

* version changed to 2.9.1

* version changed to 2.9.1

* Enabling github actions for all branch

* updated version to 2.9.1 for unity, powerflex, powerscale and powermax

* Adding the support of PStore v2.9.1

* Adding the support of PFlex v2.9.1

* Version bumpup replication 1.7.1

* Bump up version for authorization, resiliency

* update csi-metadata-retriever version to 1.6.1

* update reverseproxy version to 2.8.1

---------

Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>

* Change namespace name to match documentation. (#437)

* go-yaml version update (#438)

* go-yaml version update

* update go-yaml package to latest

* remove extra verbs

* remove duplicate verbs and add correct test files for resiliency UT

---------

Co-authored-by: Shayna Finocchiaro <[email protected]>

* [bug-1120]: Update Authorization sidecar to use insecure flag (#442)

* fix auth cert

* remove constant

* remove duplicate verbs

* reverting #426 changes (#444)

* Update final manifests for posting of Operator 1.4.1 (#445)

* KRV-20573/csm status (#446)

* add module status

* Adding CSM Module status

* Addressing the comments for PR

* Making code reusable

* Fix formatting issue

* Resolving gosec issue

* Final manifest update and apex client (#447)

* Add csm watch permissions. (#448)

* Merged CSM Module Status

* Fix App-Mob node error (#457)

Co-authored-by: abhi16394 <[email protected]>

* Bump up CSM Operator version to 1.4.2 (#458)

* update csm operator version to 1.4.2

* bump-up-op-version-1.4.2

* updated version in operator.yaml

* adding missing arg to fix e2e

* update authorization e2e (#459)

* skip cert validation in e2e (#460)

* Fixing FSGroupPolicy issue (#463)

* Fixing FSGroupPolicy issue

* Add unit test

---------

Co-authored-by: Akshay Saini <[email protected]>

* Fix for controller race, daemon status, and obs namespace  (#464)

* test controller state calc

* add debug logs

* check for driver

* add daemonnset update

* adds ns fix for when pod ns dis not csm ns

* add ns check for daemon and deployment as well

* fix typo

* fix typo

* explicitly return nil

* add missing replace statements

---------

Co-authored-by: grosnj1 <[email protected]>

* Auth proxy status fix (#465)

* actions

* working on auth proxy status check

* finished status check

* fix 1

* fix or

* code compiles

* keep auth proxy out of daemonset check

* trying to figure out deployment name

* formatting

* fix auth name in if condition

* no daemonset

* fix

* added log statements

* added another log statement

* fix log statement

* logs logs logs

* compile

* more logs

* add logs and try updating status from handlesuccess

* remove UpdateStatus call for now

* adding csm label to auth

* remove extraneous string replacement

* removing commented code

* Update actions.yml

* fix merge issue

* fix fmt

* fix pscale + obs issue  (#467)

* fix some issues

* fiix label issue, add debug logs

* add more debug

* more  debugg lines

* fix pscale issue

* remmove debug logs

* gofmt

* set available to 0 en deployment is not checked

* fix if check

---------

Co-authored-by: grosnj1 <[email protected]>

* update final manifests (#468)

* fix vetting issues (#477)

Co-authored-by: grosnj1 <[email protected]>

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>

* PR feedback

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>

* add KUBE_NODE_NAME back in

* add KUBE_NODE_NAME back in

* add KUBE_NODE_NAME back into tests

* Update dell-csm-operator.clusterserviceversion.yaml

---------

Co-authored-by: Don Khan <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: Adarsh Kumar Yadav <[email protected]>
Co-authored-by: KshitijaKakde <[email protected]>
Co-authored-by: Kshitija Kakde <[email protected]>
Co-authored-by: HarishH-DELL <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: Shayna Finocchiaro <[email protected]>
Co-authored-by: Aaron Tye <[email protected]>
Co-authored-by: Rishabh Raj <[email protected]>
Co-authored-by: panigs7 <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Chiman Jain <[email protected]>
Co-authored-by: Jooseppi Luna <[email protected]>
Co-authored-by: abhi16394 <[email protected]>
Co-authored-by: Akshay Saini <[email protected]>
Co-authored-by: grosnj1 <[email protected]>
@mjsdell mjsdell deleted the appmob-daemonset-fix branch October 17, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants