Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change namespace name to match documentation. (#437) #439

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

donatwork
Copy link
Contributor

@donatwork donatwork commented Jan 25, 2024

Description

Changed namespace used by the Dell Connectivity Client. Previously merged to release-1.4.1.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
1029

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Manual test of connectivity using the sample and validated that pod started with correct name.
  • Pod removal using updated sample file.

@donatwork donatwork merged commit e135454 into main Jan 25, 2024
7 of 8 checks passed
@donatwork donatwork deleted the acc_namespace_main branch January 25, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants