Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Capacity Tracking for CSI-Powerflex #323

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Storage Capacity Tracking for CSI-Powerflex #323

merged 1 commit into from
Aug 22, 2023

Conversation

ashleyvjoy
Copy link
Contributor

Description

This PR adds addresses changes in csm-operator to support Storage Capacity Tracking feature for PowerFlex driver

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| (dell/csm#876) |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Deployed driver using csm-operator with sct flag set to true and described csi-driver. StorageCapacity is enabled and csistoraagecapacitiesobjects are created. Successfully executed Cert-CSI test suites and StorageCapacity Functional test suites. Test Suites passed 100%
  • Deployed driver using csm-operator with sct flag set to false and described csi-driver. StorageCapacity is not enabled
sctoperatorenabled Screenshot 2023-08-17 231102
INFO 1. ScalingSuite {replicas: 2, volumes: 5, volumeSize: 8Gi}
INFO 2. CloneVolumeSuite {pods: 2, volumes: 1, volumeSize: 8Gi}
INFO 3. VolumeIoSuite {volumes: 2, volumeSize: 8Gi chains: 2-2}
INFO 4. SnapSuite {snapshots: 3, volumeSize; 8Gi}
INFO 5. ReplicationSuite {pods: 2, volumes: 5, volumeSize: 8Gi}
Does it look OK? (Y)es/(n)o
-> y
INFO Avg time of a run:   60.37s
INFO Avg time of a del:   13.81s
INFO Avg time of all:     79.24s
INFO During this run 100.0% of suites succeeded
------------------------------------------------------------
./cert-csi functional-test capacity-tracking --sc vxflexos-xfs --drns vxflexos --pi 5m
INFO Starting cert-csi; ver. 0.8.1
INFO Using EVENT observer type
INFO Using default config
INFO Successfully loaded config. Host: https://
INFO Created new KubeClient
INFO Found 1 topology segment(s) in csinode
INFO Creating capacity-tracking-4367b929 storage class
INFO Waiting for CSIStorageCapacity to be CREATED for capacity-tracking-4367b929 storage class in vxflexos namespace
INFO All CSIStorageCapacity are created in 2.005263936s
INFO Deleting capacity-tracking-4367b929 storage class,
INFO Waiting for CSIStorageCapacity to be DELETED for capacity-tracking-4367b929 storage class in vxflexos namespace
INFO All CSIStorageCapacity are deleted in 2.005498431s
INFO Updating CSIStorageCapacity for vxflexos-xfs storage class, setting capacity to 0
INFO Creating capacity-tracking-pod-d0a8eb93 pod using vxflexos-xfs storage class
INFO capacity-tracking-pod-d0a8eb93 pod is PENDING
INFO Waiting for provisioner to POLL GetCapacity for vxflexos-xfs storage class in 5m0s
INFO Provisioner POLLED GetCapacity for vxflexos-xfs storage class
INFO Waiting for pod capacity-tracking-pod-d0a8eb93 to be READY
INFO capacity-tracking-pod-d0a8eb93 pod is RUNNING
INFO SUCCESS: CapacityTrackingSuite in 1m10.092508801s
INFO Trying to connect to cluster...
INFO Created new KubeClient
INFO During this run 100.0% of suites succeeded

Copy link
Contributor

@khareRajshree khareRajshree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the e2e files and execute the e2e tests with the latest changes done for SCT.

@ashleyvjoy
Copy link
Contributor Author

Please update the e2e files and execute the e2e tests with the latest changes done for SCT.

Executed the e2e test and logs are attached in Jira.

@ashleyvjoy ashleyvjoy closed this Aug 22, 2023
@ashleyvjoy ashleyvjoy reopened this Aug 22, 2023
khareRajshree
khareRajshree previously approved these changes Aug 22, 2023
rensyct
rensyct previously approved these changes Aug 22, 2023
api/v1/types.go Outdated Show resolved Hide resolved
@ashleyvjoy ashleyvjoy dismissed stale reviews from rensyct and khareRajshree via a703dc5 August 22, 2023 05:22
khareRajshree
khareRajshree previously approved these changes Aug 22, 2023
@ashleyvjoy ashleyvjoy merged commit bf1f9c4 into main Aug 22, 2023
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@mjsdell mjsdell deleted the sct-pflex branch October 17, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants