KRV-1678 : Enhance and test install.sh script to upgrade operator and crd via cli (without OLM) in K8s and OCP environments #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikk92
requested review from
abhi16394,
alikdell,
bandak2,
bharathsreekanth,
gallacher,
JacobGros,
nb950,
jooseppi-luna,
mjsdell,
medegw01,
panigs7,
prasar6,
rajendraindukuri,
rensyct,
tdawe and
yifeijin
as code owners
rensyct
reviewed
Feb 15, 2022
scripts/install.sh
Outdated
| @@ -14,6 +14,8 @@ function usage() { | |||
| echo | |||
| echo "Usage: $PROG options..." | |||
| echo "Options:" | |||
| echo " Optional" | |||
| echo " --upgrade Perform an upgrade of the specified driver, default is false" | |||
There was a problem hiding this comment.
Perform an upgrade of the specified driver.. -> Perform an upgrade of the operator...
rensyct
reviewed
Feb 15, 2022
scripts/install.sh
Outdated
| echo "Attempting to upgrade the Operator as --upgrade option was specified" | ||
| else | ||
| log step_failure | ||
| log error "Operator is not found in dell-csm-operator namespace to upgrade.Install the operator without the upgrade option." |
There was a problem hiding this comment.
use '$NAMESPACE' instead of dell-csm-operator
rensyct
previously approved these changes
Feb 15, 2022
panigs7
reviewed
Feb 15, 2022
scripts/install.sh
Outdated
| if [ "$operator_in_namespace" = true ]; then | ||
| log step_failure | ||
| log warning "Found existing installation of dell-csm-operator in '$NAMESPACE' namespace" | ||
| log error "Remove the existing installation manually or use uninstall.sh script, and then proceed with installation" |
There was a problem hiding this comment.
Can we use error message like "Remove the existing installation using uninstall.sh script, or use the --upgrade option to upgrade the Operator" to let customer know they can use upgrade as well ?
nb950
reviewed
Feb 15, 2022
main.go
Outdated
| k8sPath = fmt.Sprintf("/driverconfig/common/default.yaml") | ||
| } else if currentVersion > maxVersion { | ||
| log.Info(fmt.Sprintf("Installed k8s version %s is greater than the maximum supported k8s version %f , hence using the latest available configurations", kubeVersion, maxVersion)) | ||
| log.Info(fmt.Sprintf("Installed k8s version %s is greater than the maximum supported k8s version %s , hence using the latest available configurations", kubeVersion, K8sMaximumSupportedVersion)) |
There was a problem hiding this comment.
use new logger log.Infof works same as Printf
karthikk92
force-pushed
the
upgrade_sript
branch
from
30596dc to
f56f653
Compare
tdawe
approved these changes
Feb 17, 2022
rensyct
approved these changes
Feb 17, 2022
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
… crd via cli (without OLM) in K8s and OCP environments (#31)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance and test install.sh script to upgrade operator and crd via cli (without OLM) in K8s and OCP environments
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?