Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-743]: Update Authorization sidecar version in driver samples #279

Merged
merged 2 commits into from
Jun 22, 2023
Merged

[feature-743]: Update Authorization sidecar version in driver samples #279

merged 2 commits into from
Jun 22, 2023

Conversation

atye
Copy link
Contributor

@atye atye commented Jun 22, 2023 •
edited
Loading

Description

Updates the csm-authorizatin-sidecar tag to v1.7.0 in the driver samples that support Authorization.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#743

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Existing tests.

hoppea2
hoppea2 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@hoppea2 hoppea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@atye atye merged commit 6446a7e into main Jun 22, 2023
@atye atye deleted the feature-743-update-samples branch June 22, 2023 18:30
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
[feature-743]: Update Authorization sidecar version in driver samples (…
63993be 
…#279)

* update sidecar version

* update config version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@alikdell alikdell alikdell approved these changes

@hoppea2 hoppea2 hoppea2 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rensyct rensyct Awaiting requested review from rensyct

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atye @hoppea2 @alikdell @shaynafinocchiaro @bharathsreekanth