Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KRV-2815 : Fallback to default configuration files when installed on unsupported versions #23

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

karthikk92
Copy link
Collaborator

@karthikk92 karthikk92 commented Feb 7, 2022

Description

Fallback to default configuration files when installed on unsupported versions

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#159

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Used 1.23 k8s system for testing and while testing modified main.go file as bellow to cover scenario:

1. If the system k8s version is more than the max supported... i.e made K8sMaximumSupportedVersion = "1.22" as bellow:

max_k8s_crossed_set_to_122

and during installation, its showing proper error message like " Installed k8s version 1.23 is less than the minimum
supported k8s version 1.2200, hence using the default configurations" as bellow

image

2. If the system k8s version is less than the min supported... i.e made K8sMinumumSupportedVersion = "1.24" as bellow :

min_k8s_crossed_set_to1 23

    and during installation, its showing proper error message like " Installed k8s version 1.23 is less than the minimum 

supported k8s version 1.2400, hence using the latest configurations" as bellow

min_k8s_crossed

3. If the system k8s version is within the range of min and max supported version than it will proceed installation without any messages as expected.

@rensyct rensyct merged commit 36d1e48 into main Feb 7, 2022
@rensyct rensyct deleted the default_config_files branch March 21, 2022 09:19
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants