KRV-2815 : Fallback to default configuration files when installed on unsupported versions #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikk92
requested review from
abhi16394,
alikdell,
bandak2,
bharathsreekanth,
gallacher,
JacobGros,
jooseppi-luna,
medegw01,
mjsdell,
nb950,
panigs7,
prasar6,
rajendraindukuri,
rensyct,
tdawe and
yifeijin
as code owners
rensyct
reviewed
Feb 4, 2022
main.go
Outdated
| log.Info(fmt.Sprintf("version %s is greater than maximum supported version of %f", kubeVersion, maxVersion)) | ||
|
|
||
| defaultConfigMax = true | ||
| log.Info(fmt.Sprintf("Installed k8s version %s is less than the minimum supported k8s version %f , hence using the latest configurations", kubeVersion, maxVersion)) |
There was a problem hiding this comment.
is less than the minimum supported -> is greater than the maximum supported...
latest configurations -> latest available configurations
karthikk92
force-pushed
the
min_k8s_version
branch
from
0e0d4a9 to
259e452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fallback to default configuration files when installed on unsupported versions
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Used 1.23 k8s system for testing and while testing modified main.go file as bellow to cover scenario:
1. If the system k8s version is more than the max supported... i.e made K8sMaximumSupportedVersion = "1.22" as bellow:
and during installation, its showing proper error message like " Installed k8s version 1.23 is less than the minimum
supported k8s version 1.2200, hence using the default configurations" as bellow
2. If the system k8s version is less than the min supported... i.e made K8sMinumumSupportedVersion = "1.24" as bellow :
supported k8s version 1.2400, hence using the latest configurations" as bellow
3. If the system k8s version is within the range of min and max supported version than it will proceed installation without any messages as expected.