Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add powerflex 2.6 features(ApproveSdc,RenameSdc) support to csm-operator #176

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Add powerflex 2.6 features(ApproveSdc,RenameSdc) support to csm-operator #176

merged 5 commits into from
Feb 23, 2023

Conversation

VamsiSiddu-7
Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 commented Feb 23, 2023 •
edited
Loading

Description

This pr adds the Support for Powerflex 2.6 features( ApproveSdc,RenameSdc) to the csm-operator

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#402
dell/csm#583

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the Powerflex Driver with csm-operator by enabling the above features
  • Tested the features

results
results2

  • Sanity Test
    sanity-test

rensyct
rensyct reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@rensyct rensyct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that these variables are also added in unit tests and e2e tests. Currently i dont see changes related to unit tests and e2e tests

pkg/drivers/powerflex.go Outdated
// ModifyPowerflexCR - Set environment variables provided in CR
func ModifyPowerflexCR(yamlString string, cr csmv1.ContainerStorageModule, fileType string) string {

approvesdcvalue := ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the naming convention for variables. Eg approveSdcValue
Same comment for line No 220 and 221

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

samples/storage_csm_powerflex_v260.yaml Outdated
# Default value: none
# Examples: "rhel-sdc", "sdc-test"
- name: X_CSI_RENAME_SDC_PREFIX
value: "sdc-test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be set to the default value which is none?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

bandak2
bandak2 previously approved these changes Feb 23, 2023
View reviewed changes
@VamsiSiddu-7
Copy link
Contributor Author

Please ensure that these variables are also added in unit tests and e2e tests. Currently i dont see changes related to unit tests and e2e tests

The Changes for the unit tests and e2e tests will come in a separate pr. fyi @abhi16394

@rajendraindukuri rajendraindukuri self-requested a review February 23, 2023 12:36
@rensyct rensyct merged commit e1f58dc into main Feb 23, 2023
@abhi16394 abhi16394 deleted the powerflex-feature branch March 20, 2023 23:37
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
@ChristianAtDell
Add powerflex 2.6 features(ApproveSdc,RenameSdc) support to csm-opera…
38678c2 
…tor (#176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@rensyct rensyct rensyct approved these changes

@bandak2 bandak2 bandak2 left review comments

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VamsiSiddu-7 @bandak2 @rensyct @rajendraindukuri @bharathsreekanth @abhi16394