added new policy in authorization to support powerflex Pre-approved g… #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleyvjoy
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
rajendraindukuri,
rensyct,
panigs7 and
tdawe
as code owners
khareRajshree
previously approved these changes
Feb 21, 2023
rensyct
previously approved these changes
Feb 21, 2023
VamsiSiddu-7
previously approved these changes
Feb 21, 2023
panigs7
previously approved these changes
Feb 21, 2023
ashleyvjoy
force-pushed
the
approvesdc-pflex
branch
from
037a9d7 to
4256982
Compare
ashleyvjoy
dismissed stale reviews from panigs7, VamsiSiddu-7, rensyct, and khareRajshree
via
270ba2b
shaynafinocchiaro
previously approved these changes
Feb 21, 2023
VamsiSiddu-7
previously approved these changes
Feb 21, 2023
rensyct
previously approved these changes
Feb 21, 2023
|
@ashleyvjoy , please sign all your commits so that the PR can be merged |
panigs7
previously approved these changes
Feb 21, 2023
ashleyvjoy
dismissed stale reviews from panigs7, rensyct, VamsiSiddu-7, and shaynafinocchiaro
via
dac543c
ashleyvjoy
force-pushed
the
approvesdc-pflex
branch
from
270ba2b to
dac543c
Compare
ashleyvjoy
force-pushed
the
approvesdc-pflex
branch
from
dac543c to
6ede2d5
Compare
shaynafinocchiaro
approved these changes
Feb 21, 2023
rensyct
approved these changes
Feb 21, 2023
VamsiSiddu-7
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uid feature
Description
Added new sdc-approve policy in Authorization policies
GitHub Issues
List the GitHub issues impacted by this PR:
| GitHub Issue # |
|https://github.com/dell/csm/issues/402|
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
--- PASS: TestCustom (22.54s)
--- PASS: TestCustom/TestAuthorizationServerReconcile (20.17s)
--- PASS: TestCustom/TestContentWatch (0.00s)
--- PASS: TestCustom/TestCsmFinalizerError (0.00s)
--- PASS: TestCustom/TestCsmPreCheckModuleError (0.00s)
--- PASS: TestCustom/TestCsmPreCheckModuleUnsupportedVersion (0.00s)
--- PASS: TestCustom/TestCsmPreCheckTypeError (0.00s)
--- PASS: TestCustom/TestCsmPreCheckVersionError (0.00s)
--- PASS: TestCustom/TestCsmUpgrade (0.02s)
--- PASS: TestCustom/TestCsmUpgradePathInvalid (0.00s)
--- PASS: TestCustom/TestCsmUpgradeSkipVersion (0.00s)
--- PASS: TestCustom/TestCsmUpgradeVersionTooOld (0.00s)
--- PASS: TestCustom/TestDeleteErrorReconcile (0.09s)
--- PASS: TestCustom/TestErrorInjection (0.70s)
--- PASS: TestCustom/TestIgnoreUpdatePredicate (0.00s)
--- PASS: TestCustom/TestOldStandAloneModuleCleanup (0.39s)
--- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success_-Disable_Components (0.01s)
--- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success-Enable_all_modules (0.01s)
--- PASS: TestCustom/TestOldStandAloneModuleCleanup/Success-_Disable_all_modules (0.37s)
--- PASS: TestCustom/TestPowerFlexAnnotation (0.00s)
--- PASS: TestCustom/TestPowerScaleAnnotation (0.00s)
--- PASS: TestCustom/TestPowerStoreAnnotation (0.00s)
--- PASS: TestCustom/TestReconcile (0.09s)
--- PASS: TestCustom/TestReconcileAuthorization (0.37s)
--- PASS: TestCustom/TestReconcileObservabilityError (0.00s)
--- PASS: TestCustom/TestRemoveDriver (0.53s)
--- PASS: TestCustom/TestRemoveDriver/getDriverConfig_error (0.00s)
--- PASS: TestCustom/TestRemoveDriver/delete_obj_not_found (0.01s)
--- PASS: TestCustom/TestRemoveDriver/get_SA_error (0.03s)
--- PASS: TestCustom/TestRemoveDriver/get_CR_error (0.03s)
--- PASS: TestCustom/TestRemoveDriver/get_CRB_error (0.04s)
--- PASS: TestCustom/TestRemoveDriver/get_CM_error (0.04s)
--- PASS: TestCustom/TestRemoveDriver/get_Driver_error (0.15s)
--- PASS: TestCustom/TestRemoveDriver/delete_SA_error (0.04s)
--- PASS: TestCustom/TestRemoveDriver/delete_Daemonset_error (0.04s)
--- PASS: TestCustom/TestRemoveDriver/delete_Deployment_error (0.04s)
--- PASS: TestCustom/TestRemoveModule (0.18s)
--- PASS: TestCustom/TestRemoveModule/csm (0.18s)
PASS
coverage: 88.6% of statements
ok command-line-arguments 22.747s coverage: 88.6% of statements