Update Authorization installation so that fields are configurable #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaynafinocchiaro
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
coulof,
Deepak-Ghivari,
gallacher,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
mjsdell,
rajendraindukuri,
rensyct,
panigs7 and
tdawe
as code owners
…operator into bugfix-633-read-custom-configs
shaynafinocchiaro
force-pushed
the
bugfix-633-read-custom-configs
branch
2 times, most recently
from
a33b567 to
2ca8d29
Compare
shaynafinocchiaro
force-pushed
the
bugfix-633-read-custom-configs
branch
from
2ca8d29 to
b6e0787
Compare
alikdell
approved these changes
Feb 14, 2023
atye
approved these changes
Feb 16, 2023
ChristianAtDell
added a commit
that referenced
this pull request
Oct 15, 2024
* read custom configurations from CRD, update image keys, and move csm-config-params configmap * update sidecar image * update unit test * fix formatting * fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to have custom values be read in from the authorization CRD, fixes an issue where the CRD didn't have unique keys, and moves the csm-config-params configMap to the authorization CRD instead of deployment.yaml to prevent incorrect key/value data when creating the configmap object.
v1.6.0 manifests are added.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
go test ./... -coverprofile cover.out
ok github.com/dell/csm-operator/pkg/modules 0.695s coverage: 88.7% of statements