Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metric Labels to Metric Names #25

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

shaynafinocchiaro
Copy link
Contributor

@shaynafinocchiaro shaynafinocchiaro commented Apr 27, 2022

Description

This PR resolves a key value association between metric IDs and metric labels. Labels will now output to the Otel Collector for any given metric.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#279

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • This has been verified against otel/opentelemetry-collector:0.42.0, Prometheus v2.34.0, Grafana v8.5.0
  • Unit Test
?       github.com/dell/csm-metrics-powerstore/cmd/metrics-powerstore   [no test files]
ok      github.com/dell/csm-metrics-powerstore/internal/common  0.215s  coverage: 91.7% of statements
ok      github.com/dell/csm-metrics-powerstore/internal/entrypoint      0.783s  coverage: 91.4% of statements
ok      github.com/dell/csm-metrics-powerstore/internal/k8s     0.192s  coverage: 91.8% of statements
?       github.com/dell/csm-metrics-powerstore/internal/k8s/mocks       [no test files]
ok      github.com/dell/csm-metrics-powerstore/internal/service 0.211s  coverage: 90.3% of statements
?       github.com/dell/csm-metrics-powerstore/internal/service/mocks   [no test files]
?       github.com/dell/csm-metrics-powerstore/opentelemetry/exporters  [no test files]
?       github.com/dell/csm-metrics-powerstore/opentelemetry/exporters/mocks    [no test files]
?       github.com/dell/csm-metrics-powerstore/opentelemetry/tracers    [no test files]

@shaynafinocchiaro
Copy link
Contributor Author

e2e pass

@shaynafinocchiaro shaynafinocchiaro merged commit 9dd3353 into main Apr 29, 2022
@shaynafinocchiaro shaynafinocchiaro deleted the bugfix-279-metric-labels branch April 29, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants