Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IP addresses in tests #20

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Update IP addresses in tests #20

merged 1 commit into from
Dec 13, 2021

Conversation

tdawe
Copy link
Collaborator

@tdawe tdawe commented Dec 10, 2021

Description

Update IP addresses used in tests that were failing the code-sanitizer

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#128

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran unit tests and code-sanitizer

@tdawe tdawe merged commit 106d577 into main Dec 13, 2021
@tdawe tdawe deleted the update-ip-addresses branch December 13, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell approved these changes

@gallacher gallacher gallacher approved these changes

@hoppea2 hoppea2 hoppea2 approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@LJ-Software LJ-Software Awaiting requested review from LJ-Software

@medegw01 medegw01 Awaiting requested review from medegw01

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tdawe @hoppea2 @gallacher @alikdell