Update actions (#95)

* consolidate actions

* linting

.github/workflows/actions.yml

@@ -1,20 +1,11 @@
 name: Workflow
-on:
+on:  # yamllint disable-line rule:truthy
   push:
     branches: [main]
   pull_request:
     branches: [main]
 jobs:
-  code-check:
-    name: Check Go formatting, linting, vetting
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout the code
-        uses: actions/checkout@v4
-      - name: Run the formatter, linter, and vetter
-        uses: dell/common-github-actions/go-code-formatter-linter-vetter@main
-        with:
-          directories: ./...
+
   sanitize:
     name: Check for forbidden words
     runs-on: ubuntu-latest
@@ -25,38 +16,7 @@ jobs:
         uses: dell/common-github-actions/code-sanitizer@main
         with:
           args: /github/workspace
-  test:
-    name: Run Go unit tests and check package coverage
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout the code
-        uses: actions/checkout@v4
-      - name: Run unit tests and check package coverage
-        uses: dell/common-github-actions/go-code-tester@main
-        with:
-          threshold: 90
-  go_security_scan:
-    name: Go security
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout the code
-        uses: actions/checkout@v4
-      - name: Run Go Security
-        uses: securego/gosec@master
-        with:
-          # exclude "G108: Profiling endpoint is automatically exposed" because we are exposing on an internal port
-          args: -exclude=G108 ./...
-  malware_security_scan:
-    name: Malware Scanner
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout the code
-        uses: actions/checkout@v4
-      - name: Run malware scan
-        uses: dell/common-github-actions/malware-scanner@main
-        with:
-          directories: .
-          options: -ri
+
   image_security_scan:
     name: Image Scanner
     runs-on: ubuntu-latest

.github/workflows/common-workflows.yaml

@@ -0,0 +1,17 @@
+name: Common Workflows
+on:  # yamllint disable-line rule:truthy
+  push:
+    branches: [main]
+  pull_request:
+    branches: ["**"]
+
+jobs:
+
+  # golang static analysis checks
+  go-static-analysis:
+    uses: dell/common-github-actions/.github/workflows/go-static-analysis.yaml@main
+    name: Golang Validation
+
+  common:
+    name: Quality Checks
+    uses: dell/common-github-actions/.github/workflows/go-common.yml@main

.github/workflows/go-version.yaml

@@ -9,7 +9,7 @@
 # Reusable workflow to perform go version update on Golang based projects
 name: Go Version Update
 
-on:
+on:  # yamllint disable-line rule:truthy
   workflow_dispatch:
   repository_dispatch:
     types: [go-update-workflow]

internal/common/testdata/invalid-format.yaml

@@ -1,2 +1 @@
 invalid_format
-

internal/common/testdata/no-global-id.yaml

@@ -6,4 +6,3 @@ arrays:
     isDefault: true
     blockProtocol: "auto"
     nasName: "nas-server"
-

internal/common/testdata/sample-config.yaml

@@ -14,4 +14,3 @@ arrays:
     password: "password"
     skipCertificateValidation: true
     blockProtocol: "FC"
-