Add one sample metric for csm-metrics-powerscale #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taohe1012
requested review from
forrestxia,
YianZong,
baoy1 and
P-Cao
as code owners
3 tasks
taohe1012
changed the title
taohe1012
force-pushed
the
feature-343-PScaleMetrics
branch
from
b6da51c to
fdcf8f9
Compare
Add a sample metric for volume to csm-metrics-powerscale, and display powerscale_volume_used_capacity_in_bytes in the Prometheus firstly: - CreateClient and GetVolumeSize from goisilon; - Implement GetPersistentVolumes and GetStorageClass from k8s; - Implement LeaderElection; - Implement asyncInstrument, metric and exporter for opentelemetry; - Push and display real-time metric value in Prometheus; - Add mockgen files, and test coverage over 90%.
taohe1012
force-pushed
the
feature-343-PScaleMetrics
branch
from
fdcf8f9 to
5f42701
Compare
|
run e2e test |
1 similar comment
|
run e2e test |
|
run e2e test |
|
run e2e test |
|
e2e pass |
forrestxia
approved these changes
Jul 8, 2022
baoy1
approved these changes
Jul 11, 2022
|
e2e pass |
|
run e2e test |
1 similar comment
|
run e2e test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a sample metric for volume to csm-metrics-powerscale, and display
powerscale_volume_used_capacity_in_bytes in the Prometheus firstly:
Note: we upgrade the OpenTelemetry to v1.7.0, and its subpackages to v0.30.0, to use Async UpDownCounter instead of Sync UpDownCounter.
According official reference, UpDownCounter :
For fetching the snapshot of the “current value” is straightforward, use Asynchronous UpDownCounter instead, not Synchronous UpDownCounter.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Add/Delete resource under the volume, the values displayed on the Promethus also increase or decrease
Manual inspection of the GUI
#I have verified that the dashboards show the data properly while generating I/O and storage resources
I have verified that the GUI of Prometheus show the data properly while generating storage resources.