Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update goisilon to v1.10.0 #14

Merged
merged 1 commit into from
Nov 30, 2022
Merged

update goisilon to v1.10.0 #14

merged 1 commit into from
Nov 30, 2022

Conversation

baoy1
Copy link
Contributor

@baoy1 baoy1 commented Nov 30, 2022

Description

Update goisilon to v1.10.0

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#491

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make check test
➜  csm-metrics-powerscale git:(feature-preview-1.1) ✗ make check test
./scripts/check.sh ./cmd/... ./opentelemetry/... ./internal/...
=== Checking format...
=== Finished  
=== Vetting...
d=== Finished 
=== Linting...
=== Finished        
=== Running gosec...
=== Finished
go test -count=1 -cover -race -timeout 30s -short `go list ./... | grep -v mocks`
?       github.com/dell/csm-metrics-powerscale/cmd/metrics-powerscale   [no test files]
ok      github.com/dell/csm-metrics-powerscale/internal/common  0.284s  coverage: 91.5% of statements
ok      github.com/dell/csm-metrics-powerscale/internal/entrypoint      1.104s coverage: 90.7% of statements
ok      github.com/dell/csm-metrics-powerscale/internal/k8s     0.075s  coverage: 94.2% of statements
ok      github.com/dell/csm-metrics-powerscale/internal/service 0.095s  coverage: 92.3% of statements
ok      github.com/dell/csm-metrics-powerscale/internal/utils   0.031s  coverage: 100.0% of statements
?       github.com/dell/csm-metrics-powerscale/opentelemetry/exporters  [no test files]

Manual inspection of the GUI

I have verified that the dashboards show the data properly while generating I/O and storage resources

  • Yes
  • No

@baoy1
Copy link
Contributor Author

baoy1 commented Nov 30, 2022

e2e pass

@baoy1 baoy1 marked this pull request as ready for review November 30, 2022 07:48
@@ -144,6 +144,7 @@ func GetPowerScaleClusters(filePath string, logger *logrus.Logger) (map[string]*
cluster.Password,
cluster.IsiPath,
cluster.IsiVolumePathPermissions,
false,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baoy1 what's the new flag meaning here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoreUnresolvableHosts
I went through gopowerscale source code, looks like ignoreUnresolvableHosts won't take effect yet. The default value is false.

@forrestxia forrestxia merged commit defd535 into main Nov 30, 2022
@forrestxia forrestxia deleted the feature-preview-1.1 branch November 30, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants