Update GO to 1.19 and format code #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baoy1
requested review from
hoppea2,
alikdell,
shaynafinocchiaro and
sharmilarama
baoy1
requested review from
forrestxia,
YianZong,
taohe1012 and
P-Cao
as code owners
forrestxia
reviewed
Oct 11, 2022
| @@ -23,6 +23,7 @@ import ( | |||
| ) | |||
|
|
|||
| // LeaderElectorGetter is an interface for initialize and check elected leader | |||
| // | |||
| //go:generate mockgen -destination=mocks/leader_elector_getter_mocks.go -package=mocks github.com/dell/csm-metrics-powerscale/internal/k8s LeaderElectorGetter | |||
There was a problem hiding this comment.
@baoy1 Curious why having those empty comments lines?
There was a problem hiding this comment.
Looks like it is new format rule in go 1.19, otherwise the format check will fail.
forrestxia
approved these changes
Oct 11, 2022
baoy1
force-pushed
the
feature-update-go-1.19
branch
2 times, most recently
from
2d3fdf0 to
5e8339f
Compare
|
run e2e test |
|
allowedlist.yaml is temporarily added to address vulnerability |
taohe1012
approved these changes
Oct 12, 2022
baoy1
force-pushed
the
feature-update-go-1.19
branch
from
5e8339f to
f276d90
Compare
|
run e2e test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update GO to 1.19 and format code
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources