Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang.org/x/net from 0.29.0 to 0.33.0 #68

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

Sahiba-Gupta
Copy link
Contributor

@Sahiba-Gupta Sahiba-Gupta commented Jan 2, 2025

Bump golang.org/x/net from 0.29.0 to 0.33.0 to fix the vulnerability found in this repo.

| GitHub Issue # |
| dell/csm#1559 |
| |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

Tested locally :

go test -count=1 -cover -race -timeout 30s -short `go list ./... | grep -v mock`
        [github.com/dell/csm-metrics-powermax/cmd/metrics-powermax](http://github.com/dell/csm-metrics-powermax/cmd/metrics-powermax)               coverage: 0.0% of statements
ok      [github.com/dell/csm-metrics-powermax/internal/common](http://github.com/dell/csm-metrics-powermax/internal/common)    1.387s  coverage: 92.3% of statements
?       [github.com/dell/csm-metrics-powermax/internal/reverseproxy/common](http://github.com/dell/csm-metrics-powermax/internal/reverseproxy/common)       [no test files]
        [github.com/dell/csm-metrics-powermax/internal/k8sutils](http://github.com/dell/csm-metrics-powermax/internal/k8sutils)          coverage: 0.0% of statements
ok      [github.com/dell/csm-metrics-powermax/internal/entrypoint](http://github.com/dell/csm-metrics-powermax/internal/entrypoint)        2.515s  coverage: 93.4% of statements
ok      [github.com/dell/csm-metrics-powermax/internal/k8s](http://github.com/dell/csm-metrics-powermax/internal/k8s)       1.145s  coverage: 94.4% of statements
        [github.com/dell/csm-metrics-powermax/internal/reverseproxy/utils](http://github.com/dell/csm-metrics-powermax/internal/reverseproxy/utils)                coverage: 0.0% of statements
ok      [github.com/dell/csm-metrics-powermax/internal/reverseproxy/config](http://github.com/dell/csm-metrics-powermax/internal/reverseproxy/config)       1.263s  coverage: 91.2% of statements
ok      [github.com/dell/csm-metrics-powermax/internal/service](http://github.com/dell/csm-metrics-powermax/internal/service)   1.102s  coverage: 100.0% of statements
?       [github.com/dell/csm-metrics-powermax/internal/service/types](http://github.com/dell/csm-metrics-powermax/internal/service/types)     [no test files]
        [github.com/dell/csm-metrics-powermax/opentelemetry/exporters](http://github.com/dell/csm-metrics-powermax/opentelemetry/exporters)            coverage: 0.0% of statements
ok      [github.com/dell/csm-metrics-powermax/internal/service/metric](http://github.com/dell/csm-metrics-powermax/internal/service/metric)    1.187s  coverage: 94.8% of statements
ok      [github.com/dell/csm-metrics-powermax/utils](http://github.com/dell/csm-metrics-powermax/utils)      1.034s  coverage: 100.0% of statements
[2:37](https://delloneisg.slack.com/archives/D087DT9PETT/p1735803458597829)
and
[2/2] STEP 2/5: LABEL vendor="Dell Inc."       name="csm-metrics-powermax"       summary="Dell Container Storage Modules (CSM) for Observability - Metrics for PowerMax"       description="Provides insight into storage usage and performance as it relates to the CSI (Container Storage Interface) Driver for Dell PowerMax"       version="2.0.0"       license="Apache-2.0"
--> a39205fd7fa4
[2/2] STEP 3/5: COPY /licenses /licenses
--> cc55151d6e8c
[2/2] STEP 4/5: COPY --from=builder /go/src/service /
--> 77200b6dd8a2
[2/2] STEP 5/5: ENTRYPOINT ["/service"]
[2/2] COMMIT csm-metrics-powermax
--> d19409c85f01
Successfully tagged localhost/csm-metrics-powermax:latest
d19409c85f0126defaf66351e634eaeed43b5b74d08a75158d0796f2938e58bd

@csmbot
Copy link
Collaborator

csmbot commented Jan 2, 2025

Can one of the admins verify this patch?

Copy link
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sahiba-Gupta Sahiba-Gupta merged commit 4ab5d73 into main Jan 2, 2025
8 checks passed
@Sahiba-Gupta Sahiba-Gupta deleted the security-bot-issue branch January 2, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants