Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dellctl schedule commands #382

Merged
merged 2 commits into from
Nov 15, 2022
Merged

dellctl schedule commands #382

merged 2 commits into from
Nov 15, 2022

Conversation

bpjain2004
Copy link
Contributor

Description

Add new dellctl commands to create and manage schedules for backups.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#491

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@@ -23,6 +23,11 @@ This document outlines all dellctl commands, their intended use, options that ca
| [dellctl restore create](#dellctl-restore-create) | Restore an application backup |
| [dellctl restore delete](#dellctl-restore-delete) | Delete application restores |
| [dellctl restore get](#dellctl-restore-get) | Get application restores |
| [dellctl schedule](#dellctl-schedule) | Allows to manipulate schedules |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "you" after "Allows"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "you" after "Allows"

done

--all Delete all schedules
--cluster-id string Id of the cluster managed by dellctl
--confirm Confirm deletion
-h, --help help for delete

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "help" to Help"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


```
--cluster-id string Id of the cluster managed by dellctl
-h, --help help for get

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "help" to "Help"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. There are several minor edits required.

rsedlock1958
rsedlock1958 previously approved these changes Nov 14, 2022
sharmilarama
sharmilarama previously approved these changes Nov 14, 2022
@bpjain2004 bpjain2004 dismissed stale reviews from sharmilarama and rsedlock1958 via 9b53ae5 November 15, 2022 05:59
@bpjain2004 bpjain2004 force-pushed the dellctl-schedule-cmds branch from 79ffce8 to 9b53ae5 Compare November 15, 2022 05:59
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prablr79 prablr79 merged commit 92d548a into release-1.5 Nov 15, 2022
@shanmydell shanmydell deleted the dellctl-schedule-cmds branch November 15, 2022 07:11
shanmydell pushed a commit that referenced this pull request Nov 25, 2022
* dellctl schedule commands

* addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants