Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vgs docs #372

Merged
merged 3 commits into from
Oct 28, 2022
Merged

update vgs docs #372

merged 3 commits into from
Oct 28, 2022

Conversation

kumarkgosa
Copy link

@kumarkgosa kumarkgosa commented Oct 27, 2022

Description

The documentation for the volume-group-snapshot common docs doesn't have the install method in it :
https://dell.github.io/csm-docs/docs/snapshots/volume-group-snapshots/
We have to jump on the github page to know about the install method or upgrade. Hence, It will be better to have it centralized in the doc portal like any other CSM module.
Also updated v1 docs just to be sure.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. There are several minor edits required.

content/docs/snapshots/volume-group-snapshots/_index.md Outdated Show resolved Hide resolved
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No edits are required.

@kumarkgosa kumarkgosa merged commit 184c718 into release-1.5 Oct 28, 2022
@kumarkgosa kumarkgosa deleted the vgs-update branch October 28, 2022 14:03
shanmydell pushed a commit that referenced this pull request Nov 25, 2022
* update vgs docs

* Update vgs doc

* Minor updates for VGS to common/V1 docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants