-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update vgs docs #372
Merged
Merged
update vgs docs #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarkgosa
requested review from
jooseppi-luna,
JacobGros,
abhi16394,
bharathsreekanth and
mbasha-dell
October 27, 2022 16:09
kumarkgosa
requested review from
gallacher,
mjsdell,
prablr79,
rajendraindukuri,
rsedlock1958 and
shanmydell
as code owners
October 27, 2022 16:09
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this. There are several minor edits required.
JacobGros
approved these changes
Oct 28, 2022
jooseppi-luna
approved these changes
Oct 28, 2022
rsedlock1958
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed this. No edits are required.
mbasha-dell
approved these changes
Oct 28, 2022
shanmydell
pushed a commit
that referenced
this pull request
Nov 25, 2022
* update vgs docs * Update vgs doc * Minor updates for VGS to common/V1 docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The documentation for the volume-group-snapshot common docs doesn't have the install method in it :
https://dell.github.io/csm-docs/docs/snapshots/volume-group-snapshots/
We have to jump on the github page to know about the install method or upgrade. Hence, It will be better to have it centralized in the doc portal like any other CSM module.
Also updated v1 docs just to be sure.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: