PowerScale Obs doc update for CSM Observability 1.3.0 #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baoy1
requested review from
hoppea2,
alikdell,
YianZong,
shaynafinocchiaro,
sharmilarama,
taohe1012,
forrestxia and
P-Cao
baoy1
requested review from
gallacher,
mjsdell,
prablr79,
rajendraindukuri,
rsedlock1958 and
shanmydell
as code owners
taohe1012
previously approved these changes
Aug 22, 2022
baoy1
force-pushed
the
feature-429-csm-obs-powerscale
branch
2 times, most recently
from
d738e38 to
df5df5b
Compare
taohe1012
previously approved these changes
Aug 22, 2022
| @@ -14,13 +14,14 @@ Description: > | |||
|
|
|||
| Metrics data is collected and pushed to the [OpenTelemetry Collector](https://github.com/open-telemetry/opentelemetry-collector), so it can be processed, and exported in a format consumable by Prometheus. SSL certificates for TLS between nodes are handled by [cert-manager](https://github.com/jetstack/cert-manager). | |||
|
|
|||
| CSM for Observability is composed of several services, each living in its own GitHub repository, that can be installed following one of the three deployments we support [here](deployment). Contributions can be made to this repository or any of the CSM for Observability repositories listed below. | |||
| CSM for Observability is composed of several services, each living in its own GitHub repository, that can be installed following one of the four deployments we support [here](deployment). Contributions can be made to this repository or any of the CSM for Observability repositories listed below. | |||
There was a problem hiding this comment.
{{<table "table table-striped table-bordered table-sm">}}
Probably github cannot render the HTML tag properly. Same for other branches, e.g. release-1.4-updated.
After publishing the doc using hugo, the HTML is correct, see http://10.225.6.31:1313/csm-docs/docs/observability/
|
|
||
| `kubectl get secret isilon-creds -n [CSI_DRIVER_NAMESPACE] -o yaml | sed 's/namespace: [CSI_DRIVER_NAMESPACE]/namespace: [CSM_NAMESPACE]/' | kubectl create -f -` | ||
|
|
||
| If [CSM for Authorization is enabled](../../../authorization/deployment/#configuring-a-dell-csi-driver-with-csm-for-authorization) for CSI PowerScale, perform the following steps: |
There was a problem hiding this comment.
Change "the following" to "these"
| ## Offline Installer Upgrade | ||
|
|
||
| Assuming that you have already installed the Karavi Observability Helm Chart by offline installer and meet its installation requirement. | ||
| The following instructions can be followed when a Helm chart was installed and will be upgraded in an environment that does not have an internet connection and will be unable to download the Helm chart and related Docker images. |
There was a problem hiding this comment.
Change "The following" to "These"
baoy1
force-pushed
the
feature-429-csm-obs-powerscale
branch
from
df5df5b to
83ca75f
Compare
All addressed. Thank you! |
forrestxia
approved these changes
Aug 23, 2022
taohe1012
approved these changes
Aug 23, 2022
P-Cao
approved these changes
Aug 23, 2022
YianZong
approved these changes
Aug 23, 2022
|
Hi @rsedlock1958 , @gallacher, @mjsdell , @prablr79, @rajendraindukuri, @shanmydell, any more comments prior to your approvals? |
shanmydell
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CSM observability for PowerScale to csm-docs, and update docs for online/offline install and upgrade.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: