Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static provisioning example to PowerFlex #321

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

falfaroc
Copy link
Contributor

Description

It was identified that documentation for creating static provisioning on PowerFlex was missing. Similar to other drivers that support this feature, a section for the documentation was added for consistency.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#350

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. There are a couple of minor edits.

@falfaroc falfaroc force-pushed the powerflex-static-provisioning branch from d142d1f to 038b0ad Compare August 19, 2022 15:43
@ChristianAtDell
Copy link
Contributor

When I was attempting to static-provision from PowerFlex recently, I had trouble getting the volume's ID.

To get it, I used scli on the PowerFlex array to query the volume by its name.

Using the UI is a much more convenient way to obtain the ID and is certainly more in line with the PowerStore method of getting the volume. However, the instructions are unclear to me:

  1. Open your volume in the PowerFlex Management UI. Filter by just your volume and the volume ID can be located in the URL.

I'm looking at the PowerFlex UI right now and I don't see any clear way to filter based on the volume.

image

I think clearer directions on how to do this filtering would be helpful.

content/docs/csidriver/features/powerflex.md Outdated Show resolved Hide resolved
@bharathsreekanth
Copy link

Good point Christian. Could you provide the scli cmd you used, we can add that. PowerFlex UI is not as intuitive or powerful as PowerStore UI.

JacobGros
JacobGros previously approved these changes Aug 19, 2022
@ChristianAtDell
Copy link
Contributor

ChristianAtDell commented Aug 19, 2022

Good point Christian. Could you provide the scli cmd you used, we can add that. PowerFlex UI is not as intuitive or powerful as PowerStore UI.

Credit goes to Don Khan for finding these cmds out:

scli --mdm_ip (IPs, comma separated) --login --username (user) --password (pass)
scli --vol --query_volume --volume_name (name)

I do recommend expanding on the UI version's directions as well, though, for ease of use.

@bharathsreekanth
Copy link

Good point Christian. Could you provide the scli cmd you used, we can add that. PowerFlex UI is not as intuitive or powerful as PowerStore UI.

Credit goes to Don Khan for finding these cmds out:

scli --mdm_ip <IPs, comma separated> --login --username --password scli --vol --query_volume --volume_name

I do recommend expanding on the UI version's directions as well, though, for ease of use.

I looked around in the UI and I was not able to find a way to get the Id.

@falfaroc
Copy link
Contributor Author

@ChristianAtDell @bharathsreekanth The only way I was able to get the volume ID through the UI is by clicking the volume in the topology section which filters for only that volume. Afterwards, in the URL, the volume UUID is present.

image

image

I will update the documentation to include both the scli commands and the ui approaches.

@bharathsreekanth
Copy link

@ChristianAtDell @bharathsreekanth The only way I was able to get the volume ID through the UI is by clicking the volume in the topology section which filters for only that volume. Afterwards, in the URL, the volume UUID is present.

image

image

I will update the documentation to include both the scli commands and the ui approaches.

Thanks Fernando. It is not really easy for one to know that is the ID of the volume. I suppose we could add a footnote below the documentation to tell how to get the ID. I am not a fan of it, but I dont see any easy way. Thoughts?

@donatwork
Copy link
Contributor

@ChristianAtDell @bharathsreekanth The only way I was able to get the volume ID through the UI is by clicking the volume in the topology section which filters for only that volume. Afterwards, in the URL, the volume UUID is present.
image
image
I will update the documentation to include both the scli commands and the ui approaches.

Thanks Fernando. It is not really easy for one to know that is the ID of the volume. I suppose we could add a footnote below the documentation to tell how to get the ID. I am not a fan of it, but I dont see any easy way. Thoughts?

I'm not a fan of the URL approach. That may be useful as a hint or note but not as main line documentation. We should just document the scli option as a PowerFlex user should already be familiar with scli. Put the UI hint in a note.

@falfaroc falfaroc dismissed stale reviews from JacobGros and bharathsreekanth via 6702d64 August 22, 2022 14:37
@falfaroc falfaroc force-pushed the powerflex-static-provisioning branch from 038b0ad to 6702d64 Compare August 22, 2022 14:37
@bharathsreekanth
Copy link

I did confirm with Powerflex engg team that there is no easy from UI to get this. Let us rely on the scli for now.

@donatwork
Copy link
Contributor

I did confirm with Powerflex engg team that there is no easy from UI to get this. Let us rely on the scli for now.

Can we open an enhancement request so that the ID is available in the UI.

@bharathsreekanth
Copy link

I did confirm with Powerflex engg team that there is no easy from UI to get this. Let us rely on the scli for now.

Can we open an enhancement request so that the ID is available in the UI.

I asked them that. waiting to hear back

JacobGros
JacobGros previously approved these changes Aug 22, 2022
@falfaroc falfaroc requested a review from rsedlock1958 August 22, 2022 18:41
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. There is one minor edit.

@falfaroc falfaroc dismissed stale reviews from JacobGros and bharathsreekanth via 2e01501 August 22, 2022 19:14
@falfaroc falfaroc force-pushed the powerflex-static-provisioning branch from 6702d64 to 2e01501 Compare August 22, 2022 19:14
@falfaroc falfaroc requested a review from rsedlock1958 August 22, 2022 19:15
rsedlock1958
rsedlock1958 previously approved these changes Aug 22, 2022
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. No edits required.

abhi16394
abhi16394 previously approved these changes Aug 22, 2022
JacobGros
JacobGros previously approved these changes Aug 22, 2022
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No edits are reqired.

@falfaroc falfaroc merged commit 78b1ee3 into release-1.4-updated Aug 23, 2022
@shanmydell shanmydell deleted the powerflex-static-provisioning branch July 20, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants