Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Mobility Documentation #318

Merged
merged 13 commits into from
Aug 19, 2022
Merged

Application Mobility Documentation #318

merged 13 commits into from
Aug 19, 2022

Conversation

tdawe
Copy link
Contributor

@tdawe tdawe commented Aug 17, 2022

Description

Application Mobility Documentation

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#350

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@tdawe tdawe marked this pull request as draft August 17, 2022 14:22
rsedlock1958
rsedlock1958 reviewed Aug 17, 2022
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. Several edits are required.

content/docs/application-mobility/deployment.md Outdated Show resolved Hide resolved
content/docs/application-mobility/troubleshooting.md Outdated Show resolved Hide resolved
content/docs/application-mobility/use_cases.md Outdated Show resolved Hide resolved
content/docs/application-mobility/use_cases.md Outdated Show resolved Hide resolved
content/docs/application-mobility/use_cases.md Outdated Show resolved Hide resolved
content/docs/application-mobility/use_cases.md Outdated Show resolved Hide resolved
@tdawe tdawe marked this pull request as ready for review August 17, 2022 16:15
@tdawe tdawe force-pushed the app-mobility-docs-tech-preview branch from 56c365b to 6d2a157 Compare August 18, 2022 18:06
alexemc
alexemc requested changes Aug 18, 2022
View reviewed changes
Copy link

@alexemc alexemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor comments that I left, I suggest removing redundant "Dell Container Storage Modules (CSM) for" and "CSM for" throughout the App Mobility documentation.

content/docs/application-mobility/_index.md Outdated Show resolved Hide resolved
content/docs/application-mobility/deployment.md Outdated Show resolved Hide resolved
content/docs/application-mobility/troubleshooting.md Outdated Show resolved Hide resolved
alexemc
alexemc previously approved these changes Aug 18, 2022
View reviewed changes
@tdawe tdawe requested a review from rsedlock1958 August 19, 2022 16:16
@tdawe tdawe merged commit a432f13 into release-1.4-updated Aug 19, 2022
@tdawe tdawe deleted the app-mobility-docs-tech-preview branch August 19, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@alexemc alexemc alexemc approved these changes

@gallacher gallacher Awaiting requested review from gallacher

@mjsdell mjsdell Awaiting requested review from mjsdell

@prablr79 prablr79 Awaiting requested review from prablr79

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@shanmydell shanmydell Awaiting requested review from shanmydell

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@rbo54 rbo54 Awaiting requested review from rbo54

@anathoodell anathoodell Awaiting requested review from anathoodell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tdawe @alexemc @bpjain2004 @sharmilarama @rsedlock1958