Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dellctl- support cluster registration with uids #311

Merged
merged 2 commits into from
Aug 18, 2022
Merged

dellctl- support cluster registration with uids #311

merged 2 commits into from
Aug 18, 2022

Conversation

bpjain2004
Copy link
Contributor

@bpjain2004 bpjain2004 commented Aug 12, 2022 •
edited by gallacher
Loading

Description

Now dellctl supports cluster registration with optional uids. This PR is to reflect the same changes in documentation.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#449

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

rsedlock1958
rsedlock1958 reviewed Aug 12, 2022
View reviewed changes
Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this. No edits are required.

tdawe
tdawe reviewed Aug 12, 2022
View reviewed changes
content/docs/cli/_index.md Outdated
cluster1 v1.22 https://1.2.3.4:6443
cluster2 v1.22 https://1.2.3.5:6443
CLUSTER ID VERSION URL UID
cluster1 v1.22 https://10.225.7.48:6443
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mask out internal IPs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@shanmydell shanmydell merged commit 9d57b4e into release-1.4-updated Aug 18, 2022
@shanmydell shanmydell deleted the dellctl-support-clusters-with-uids branch August 18, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsedlock1958 rsedlock1958 rsedlock1958 left review comments

@shanmydell shanmydell shanmydell approved these changes

@sharmilarama sharmilarama sharmilarama approved these changes

@tdawe tdawe tdawe approved these changes

@gallacher gallacher Awaiting requested review from gallacher

@mjsdell mjsdell Awaiting requested review from mjsdell

@prablr79 prablr79 Awaiting requested review from prablr79

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bpjain2004 @tdawe @sharmilarama @rsedlock1958 @shanmydell