Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Observability Post Installation Dependency Issues #211

Merged
merged 1 commit into from
May 12, 2022

Conversation

shaynafinocchiaro
Copy link
Contributor

Description

This PR fixes a formatting issue in prometheus-values.yaml as well as the Prometheus data source url for Grafana. It also revises the supported version for Prometheus to match the tag version in prometheus-values.yaml.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#259
dell/csm#278

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

Copy link
Contributor

@sharmilarama sharmilarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanmydell shanmydell merged commit 96e62b7 into release-1.2.1-csm May 12, 2022
@shanmydell shanmydell deleted the bugfix-259-278-obs-dependencies branch May 12, 2022 04:22
hoppea2 pushed a commit that referenced this pull request May 24, 2022
* patch version updates

* update module version

* update release navigation

* fix formatting and prometheus data source url (#211)

Co-authored-by: Yamunadevi N Shanmugam <[email protected]>
Co-authored-by: shaynafinocchiaro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants