Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common changes for Drivers and modules #174

Merged
merged 51 commits into from
Mar 8, 2022
Merged

Conversation

shanmydell
Copy link
Collaborator

@shanmydell shanmydell commented Mar 8, 2022

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#128

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

shanmydell and others added 30 commits March 2, 2022 17:39
mahesr2
mahesr2 previously approved these changes Mar 8, 2022
Copy link

@mahesr2 mahesr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sakshi-dell
Sakshi-dell previously approved these changes Mar 8, 2022
@shanmydell shanmydell requested a review from francis-nijay March 8, 2022 11:27
francis-nijay
francis-nijay previously approved these changes Mar 8, 2022
@@ -32,26 +32,25 @@ The CSI Drivers by Dell implement an interface between [CSI](https://kubernetes-
{{<table "table table-striped table-bordered table-sm">}}
| Features | PowerMax | PowerFlex | Unity | PowerScale | PowerStore |
|--------------------------|:--------:|:---------:|:------:|:----------:|:----------:|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line is missing you need check the format here.

@delldubey delldubey dismissed stale reviews from francis-nijay, Sakshi-dell, and mahesr2 via ed9eec1 March 8, 2022 12:04
mahesr2
mahesr2 previously approved these changes Mar 8, 2022
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanmydell shanmydell merged commit 809b7e5 into release-1.2 Mar 8, 2022
@shanmydell shanmydell deleted the common-doc-PR-2 branch March 8, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.