-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fsgroupolicy changes for powerscale #159
Conversation
@nitesh3108 Please move this PR release branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@nitesh3108 please resolve the conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls rebase ur branch
|
||
fsGroupPolicy will be default to "ReadWriteOnceWithFSType", keeping the previous behavior. | ||
|
||
Note: FSGroupPolicy may not work as expected with "root_squash", to get the desired behavior "no_root_squash" has to be enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls mention in terms of RootClientEnabled and not root squash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
root_squash and no_root_squash must be enough.
i.e.
no_root_squash --> RootClient=true
root_squash --> RootClient=false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still we should go with the option what we provide.
I see multiple changes for other drivers, it that expected to be in this PR ? |
e3d32ef
to
e62e399
Compare
@@ -565,3 +565,19 @@ When this feature is enabled, the existing `ReadWriteOnce(RWO)` access mode rest | |||
|
|||
To migrate existing PersistentVolumes to use `ReadWriteOncePod`, please follow the instruction from [here](https://kubernetes.io/blog/2021/09/13/read-write-once-pod-access-mode-alpha/#migrating-existing-persistentvolumes). | |||
|
|||
## FSGroupPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nitesh3108 I don't think we need to mention this under feature since this is already available by default even in the previous release right? Also, we have not implemented anything and we just gave the option to configure with values file
I haven't mentioned this as a feature in csi-powerstore docs.
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: