Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSGroup doc update #153

Merged
merged 1 commit into from
Feb 25, 2022
Merged

FSGroup doc update #153

merged 1 commit into from
Feb 25, 2022

Conversation

harishp8889
Copy link
Contributor

@harishp8889 harishp8889 commented Feb 24, 2022 •
edited
Loading

Description

Updated documentation for FSGroup policy

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#167

Checklist:

  • Have you run grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@harishp8889 harishp8889 self-assigned this Feb 24, 2022
shanmydell
shanmydell requested changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this to be added to the features file? Release notes?

@harishp8889
Copy link
Contributor Author

Do we need this to be added to the features file? Release notes?

We have not explicitly implemented anything, This is available in Kubernetes and enabled by default from the 1.20 release, We are just providing an option to set the required FSGroup policy in the CSI driver - I don't see any need to mention it in either release notes or feature page

AronAtDell
AronAtDell approved these changes Feb 24, 2022
View reviewed changes
Copy link

@AronAtDell AronAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fairly straightforward! Thanks! All set!

@rsedlock1958
Copy link

I have reviewed this. No edits are required.

shanmydell
shanmydell approved these changes Feb 25, 2022
View reviewed changes
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@randeepsharma will take care in common PowerScale PR

@harishp8889 harishp8889 force-pushed the feature/fsgroupPolicy branch from e5ceec9 to b56093d Compare February 25, 2022 08:05
@harishp8889 harishp8889 merged commit 0304bbd into main Feb 25, 2022
@shanmydell shanmydell deleted the feature/fsgroupPolicy branch March 14, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanmydell shanmydell shanmydell approved these changes

@AronAtDell AronAtDell AronAtDell approved these changes

@prablr79 prablr79 prablr79 approved these changes

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@randeepdell randeepdell Awaiting requested review from randeepdell

Assignees

@harishp8889 harishp8889

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harishp8889 @rsedlock1958 @prablr79 @AronAtDell @shanmydell