Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Resiliency documentation for pod affinity and kubelet failure #141

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

alikdell
Copy link
Contributor

@alikdell alikdell commented Feb 15, 2022

Update Resiliency documentation for pod affinity and kubelet failure

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#dell/csm#87
#dell/csm#165

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@shaynafinocchiaro
Copy link
Contributor

shaynafinocchiaro commented Feb 17, 2022

LGTM but you will want to merge into the release-1.2 branch instead of main

atye
atye previously approved these changes Feb 18, 2022
@shanmydell shanmydell self-requested a review February 18, 2022 13:18
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has to be release branch

@@ -38,7 +38,7 @@ CSM for Resiliency provides the following capabilities:
{{<table "table table-striped table-bordered table-sm">}}
| COP/OS | Supported Versions |
|-|-|
| Kubernetes | 1.20, 1.21, 1.22 |
| Kubernetes | 1.20, 1.21, 1.22 1.23 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove 1.20 if we are only supporting n-2 releases

@alikdell alikdell changed the base branch from main to release-1.2 February 18, 2022 15:36
@alikdell alikdell dismissed stale reviews from atye and shaynafinocchiaro February 18, 2022 15:36

The base branch was changed.

atye
atye previously approved these changes Feb 18, 2022
@alikdell alikdell dismissed shanmydell’s stale review February 18, 2022 20:09

Base branch changed to release1.2

@alikdell alikdell merged commit e277fe8 into release-1.2 Feb 21, 2022
@alikdell alikdell deleted the resiliency-doc-update branch February 21, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants