Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifiable values consistent across drivers #1398

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Modifiable values consistent across drivers #1398

merged 1 commit into from
Dec 19, 2024

Conversation

rishabhatdell
Copy link
Contributor

Description

This PR made modifiable values in CSM installation wizard values.yaml consistent across drivers

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1647

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 51b349e. ± Comparison against base commit 856333b.

rajkumar-palani
rajkumar-palani approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rishabhatdell rishabhatdell merged commit 3571869 into main Dec 19, 2024
7 checks passed
@suryagupta4 suryagupta4 deleted the consistency_all_driver branch December 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@shanmydell shanmydell shanmydell approved these changes

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rishabhatdell @rajkumar-palani @shanmydell @suryagupta4