Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the default values of parameter of driver deployed via csm-operator and removed the broken link #1393

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Updated the default values of parameter of driver deployed via csm-operator and removed the broken link #1393

merged 6 commits into from
Dec 10, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Dec 10, 2024 •
edited
Loading

Description

  • Updated the proper default values of parameter of driver deployed via csm-operator.
  • Removed the broken link and note associated to it as it is not necessary anymore.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1615
dell/csm#1559

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 10, 2024 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit f3a846d. ± Comparison against base commit c1b60e8.

♻️ This comment has been updated with latest results.

@chimanjain chimanjain marked this pull request as ready for review December 10, 2024 09:10
@chimanjain chimanjain changed the title Updated the proper default values of parameter of driver and removed the broken link Updated the default values of parameter of driver deployed via csm-operator and removed the broken link Dec 10, 2024
shefali-malhotra
shefali-malhotra approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rajkumar-palani
rajkumar-palani approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prablr79
prablr79 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chimanjain chimanjain merged commit f6ac493 into main Dec 10, 2024
7 checks passed
@chimanjain chimanjain deleted the upd-values branch December 10, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@panigs7 panigs7 panigs7 approved these changes

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@prablr79 prablr79 prablr79 approved these changes

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chimanjain @prablr79 @rajkumar-palani @shefali-malhotra @panigs7 @HarishH-DELL