Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realign tables and make access mode support more clear #133

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Realign tables and make access mode support more clear #133

merged 2 commits into from
Feb 17, 2022

Conversation

coulof
Copy link
Collaborator

@coulof coulof commented Feb 3, 2022

Description

The support for access mode row was a bit confusing.
Trying to make it more meaningful
table_access_mode

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@tdawe
Copy link
Contributor

tdawe commented Feb 3, 2022

Can you create a branch off of release-1.2 and then target the PR at that branch. Thanks

@coulof coulof changed the base branch from main to release-1.2 February 4, 2022 10:17
@coulof
Copy link
Collaborator Author

coulof commented Feb 4, 2022

Merge in release-1.2 branch and resolved conflict.

@shanmydell
Copy link
Collaborator

Verified using local deployment

shanmydell
shanmydell previously approved these changes Feb 14, 2022
View reviewed changes
walker2
walker2 previously approved these changes Feb 14, 2022
View reviewed changes
@coulof coulof dismissed stale reviews from walker2 and shanmydell via e160199 February 15, 2022 13:22
@coulof
Copy link
Collaborator Author

coulof commented Feb 15, 2022

@shanmydell, @walker2 & @tdawe could you reapprove the changes ?
For some reason, some of my commits were unsigned and I couldn't merge.

gallacher
gallacher approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coulof coulof merged commit 0f2c35c into release-1.2 Feb 17, 2022
@coulof coulof deleted the access-mode branch March 2, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallacher gallacher gallacher approved these changes

@walker2 walker2 walker2 approved these changes

@shanmydell shanmydell shanmydell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@coulof @tdawe @shanmydell @walker2 @gallacher