Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional sdc documentation #1274

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Add optional sdc documentation #1274

merged 2 commits into from
Oct 10, 2024

Conversation

falfaroc
Copy link
Contributor

@falfaroc falfaroc commented Oct 8, 2024 •
edited
Loading

Description

Add information of the optional SDC feature for Powerflex.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#663

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 6024ec2. ± Comparison against base commit 4dbcee8.

♻️ This comment has been updated with latest results.

@falfaroc falfaroc force-pushed the add-sdc-optional-doc branch from ff25955 to 7ef36b1 Compare October 8, 2024 15:16
@falfaroc falfaroc marked this pull request as ready for review October 8, 2024 15:19
bharathsreekanth
bharathsreekanth previously requested changes Oct 8, 2024
View reviewed changes
content/docs/csidriver/features/powerflex.md Outdated Show resolved Hide resolved
content/docs/csidriver/features/powerflex.md Outdated Show resolved Hide resolved
content/docs/csidriver/features/powerflex.md Outdated Show resolved Hide resolved
mjsdell
mjsdell approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@mjsdell mjsdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@falfaroc falfaroc force-pushed the add-sdc-optional-doc branch from 4b90fea to 6024ec2 Compare October 10, 2024 17:26
@falfaroc falfaroc requested a review from xuluna October 10, 2024 17:27
@falfaroc falfaroc merged commit b8d1f2e into main Oct 10, 2024
7 checks passed
@falfaroc falfaroc deleted the add-sdc-optional-doc branch October 10, 2024 18:47
coulof pushed a commit that referenced this pull request Oct 21, 2024
@falfaroc @coulof
Add optional sdc documentation (#1274)
becfa11 
* Add optional sdc documentation

* Address PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@mjsdell mjsdell mjsdell approved these changes

@xuluna xuluna xuluna approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@tdawe tdawe Awaiting requested review from tdawe

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@kumarp20 kumarp20 Awaiting requested review from kumarp20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@falfaroc @xuluna @AronAtDell @mjsdell @bharathsreekanth