Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation example - Installation helm page of unity XT with supported K8s #119

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Update installation example - Installation helm page of unity XT with supported K8s #119

merged 2 commits into from
Feb 25, 2022

Conversation

karthikk92
Copy link
Contributor

Description

Update installation example - Installation helm page of unity XT with supported K8s

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#128

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

shanmydell
shanmydell previously approved these changes Jan 11, 2022
View reviewed changes
AronAtDell
AronAtDell previously approved these changes Jan 11, 2022
View reviewed changes
Copy link

@AronAtDell AronAtDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comment everything looks good. Thanks!

@shanmydell shanmydell dismissed stale reviews from AronAtDell and themself via ede14b2 January 20, 2022 13:38
shanmydell
shanmydell requested changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls address review comments from Aron

@karthikk92
Copy link
Contributor Author

Pls address review comments from Aron

Taken care @shanmydell

shanmydell
shanmydell previously approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@shanmydell shanmydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rensyct rensyct self-requested a review February 9, 2022 05:33
rensyct
rensyct previously approved these changes Feb 9, 2022
View reviewed changes
@karthikk92 karthikk92 dismissed stale reviews from rensyct and shanmydell via 02ba6fa February 9, 2022 08:11
@shanmydell
Copy link
Collaborator

@karthikk92 : pls rebase the code

@mjsdell
Copy link
Collaborator

mjsdell commented Feb 24, 2022

@karthikk92 please rebase

@shanmydell shanmydell merged commit 5fe7e10 into release-1.2 Feb 25, 2022
@shanmydell shanmydell deleted the helm_example branch February 25, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct approved these changes

@shanmydell shanmydell shanmydell approved these changes

@AronAtDell AronAtDell AronAtDell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karthikk92 @shanmydell @mjsdell @AronAtDell @rensyct