-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligned release-1.10.1 branch with only fix for https://github.com/dell/csm/issues/1210 #1050
Conversation
Test Results76 tests 76 ✅ 3s ⏱️ Results for commit f9cf0c4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
### Verify Installation of the CSM Authorization Proxy Server | ||
Once the Authorization CR is created, you can verify the installation as mentioned below: | ||
|
||
```bash | ||
kubectl describe csm/<name-of-custom-resource> -n authorization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change for? Is there another ticket related to this? And also the above deletions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the other PR we state that "Use the default namespace “authorization” for installing Authorization using CSM Operator." https://github.com/dell/csm/pull/1211/files. Now if this statements i true "CSM Operator does not support dynamic namespaces for Authorization. Despite successful installation in a namespace other than "authorization", errors may arise during volume creation. Use the default namespace “authorization” for installing Authorization using CSM Operator." why not have that reflected as such instead of below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier dell/csm#1205 was targeted for CSM 1.10.1 and hence this was added here. This PR is simply reverting that change.
We have raised a new PR #1052 to address these changes along with adding dell/csm#1205 as a known issue for CSM 1.10.1 and pull changes that went into main branch after the release. |
Description
Reverted changes from release-1.10.1 and rolled them in release-1.10.2.
Also added fixed bug to list of fixed bugs for PowerFlex.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: