Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned release-1.10.1 branch with only fix for https://github.com/dell/csm/issues/1210 #1050

Closed
wants to merge 2 commits into from

Conversation

gallacher
Copy link
Contributor

Description

Reverted changes from release-1.10.1 and rolled them in release-1.10.2.

Also added fixed bug to list of fixed bugs for PowerFlex.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1210

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@gallacher gallacher changed the title Reverted changes from release-1.10.1 and rolled them in release-1.10.2 Aligned release-1.10.1 branch with only fix for https://github.com/dell/csm/issues/1210 Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Test Results

76 tests   76 ✅  3s ⏱️
 3 suites   0 💤
 1 files     0 ❌

Results for commit f9cf0c4.

Copy link
Collaborator

@mjsdell mjsdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

### Verify Installation of the CSM Authorization Proxy Server
Once the Authorization CR is created, you can verify the installation as mentioned below:

```bash
kubectl describe csm/<name-of-custom-resource> -n authorization

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change for? Is there another ticket related to this? And also the above deletions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other PR we state that "Use the default namespace “authorization” for installing Authorization using CSM Operator." https://github.com/dell/csm/pull/1211/files. Now if this statements i true "CSM Operator does not support dynamic namespaces for Authorization. Despite successful installation in a namespace other than "authorization", errors may arise during volume creation. Use the default namespace “authorization” for installing Authorization using CSM Operator." why not have that reflected as such instead of below?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Earlier dell/csm#1205 was targeted for CSM 1.10.1 and hence this was added here. This PR is simply reverting that change.

@AkshaySainiDell
Copy link
Contributor

We have raised a new PR #1052 to address these changes along with adding dell/csm#1205 as a known issue for CSM 1.10.1 and pull changes that went into main branch after the release.

@gallacher gallacher deleted the revert-changes-for-1-10-2 branch August 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants