Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KRV-2321 : Updating side cars to the latest version #62

Merged
merged 3 commits into from
Feb 10, 2022
Merged

KRV-2321 : Updating side cars to the latest version #62

merged 3 commits into from
Feb 10, 2022

Conversation

karthikk92
Copy link
Collaborator

@karthikk92 karthikk92 commented Feb 10, 2022 •
edited
Loading

Description

Updating side cars to the latest version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#182

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Tested in 1.23, 1.22 version of k8s and working as expected.

Also tested creation of

  1. snapshot from pvc
  2. create pvc from snapshot
  3. creation of po from the pvc generated from snapshot

Please find attached screenshots:
1

2

3

panigs7
panigs7 previously approved these changes Feb 10, 2022
View reviewed changes
@karthikk92 karthikk92 merged commit 2640c32 into main Feb 10, 2022
@karthikk92 karthikk92 deleted the sidecar_version_changes branch February 10, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rensyct rensyct rensyct approved these changes

@bandak2 bandak2 bandak2 approved these changes

@panigs7 panigs7 panigs7 left review comments

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@gallacher gallacher Awaiting requested review from gallacher

@prasar6 prasar6 Awaiting requested review from prasar6

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthikk92 @bandak2 @rensyct @panigs7