Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KRV-2731 : Verification of secrets repeated twice while installation of driver via helm #57

Closed
wants to merge 1 commit into from
Closed

KRV-2731 : Verification of secrets repeated twice while installation of driver via helm #57

wants to merge 1 commit into from

Conversation

karthikk92
Copy link
Collaborator

Description

Verification of secrets repeated twice while installation of driver via helm

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#168

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

2

rensyct
rensyct previously approved these changes Feb 2, 2022
View reviewed changes
panigs7
panigs7 previously approved these changes Feb 2, 2022
View reviewed changes
@karthikk92 karthikk92 dismissed stale reviews from panigs7 and rensyct via 6703152 February 2, 2022 07:08
@karthikk92 karthikk92 force-pushed the heml_install_changes branch from a0be5b0 to 6703152 Compare February 2, 2022 07:08
@panigs7 panigs7 force-pushed the heml_install_changes branch from 6703152 to 115d00d Compare February 2, 2022 07:24
@karthikk92 karthikk92 closed this Feb 2, 2022
@karthikk92 karthikk92 deleted the heml_install_changes branch March 21, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panigs7 panigs7 panigs7 left review comments

@rensyct rensyct rensyct left review comments

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@gallacher gallacher Awaiting requested review from gallacher

@prasar6 prasar6 Awaiting requested review from prasar6

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karthikk92 @rensyct @panigs7