KRV-2251 : Removing 1.20 yaml and adding 1.23 yaml #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikk92
requested review from
bandak2,
francis-nijay,
gallacher,
panigs7,
prasar6,
rajendraindukuri and
rensyct
as code owners
rensyct
reviewed
Jan 10, 2022
helm/csi-unity/Chart.yaml
Outdated
| kubeVersion: ">= 1.20.0 <= 1.23.0" | ||
| version: 2.2.0 | ||
| appVersion: 2.2.0 | ||
| kubeVersion: ">= 1.20 <= 1.23" |
There was a problem hiding this comment.
should this not be >- 1.21?
karthikk92
force-pushed
the
k8s_version_change
branch
from
011e2db to
cecf6f2
Compare
rajendraindukuri
previously approved these changes
Jan 18, 2022
panigs7
previously approved these changes
Jan 18, 2022
rensyct
reviewed
Jan 18, 2022
| @@ -7,7 +7,7 @@ Return the appropriate sidecar images based on k8s version | |||
| {{- print "k8s.gcr.io/sig-storage/csi-attacher:v3.1.0" -}} | |||
| {{- else if and (ge (trimSuffix "+" .Capabilities.KubeVersion.Minor) "20") (le (trimSuffix "+" .Capabilities.KubeVersion.Minor) "21") -}} | |||
There was a problem hiding this comment.
why are we keeping checks for non supported K8s versions 1.19 and 1.20.. This comment is for all the sidecars in this file.
rensyct
approved these changes
Jan 18, 2022
rajendraindukuri
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing 1.20 yaml and adding 1.23 yaml
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: