Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver version bump up for CSM 1.12 #228

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Driver version bump up for CSM 1.12 #228

merged 2 commits into from
Sep 3, 2024

Conversation

WilsonRadadia20
Copy link
Contributor

Description

CSI-Unity Driver version bump up for CSM 1.12.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Done basic sanity testing and ran cert-csi suite

@WilsonRadadia20
Copy link
Contributor Author

  1. Successful installation of Unity driver:
    image

  2. Pods Status:
    image

  3. Sanity test result:
    image

suryagupta4
suryagupta4 previously approved these changes Sep 3, 2024
View reviewed changes
rishabhatdell
rishabhatdell requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@rishabhatdell rishabhatdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version here:

csi-unity/Dockerfile.podman

Line 31 in 2dbb3ed

version="2.11.0" \

@WilsonRadadia20
Copy link
Contributor Author

Update version here:

csi-unity/Dockerfile.podman

Line 31 in 2dbb3ed

version="2.11.0" \

Changes have been made.

@WilsonRadadia20 WilsonRadadia20 merged commit c5048a3 into main Sep 3, 2024
5 checks passed
@suryagupta4 suryagupta4 deleted the csiunity-version-update branch September 3, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhatdell rishabhatdell rishabhatdell approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari Deepak-Ghivari is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@WilsonRadadia20 @rajendraindukuri @AkshaySainiDell @suryagupta4 @adarsh-dell @rishabhatdell