-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update offline installer to ignore comments in the manifests. #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigobassil
requested review from
atye,
bandak2,
bogdanNovikovDell,
Deepak-Ghivari,
francis-nijay,
karthikk92,
Leonard-Dell,
mdutka-dell,
panigs7,
rajendraindukuri and
shaynafinocchiaro
as code owners
August 28, 2024 15:08
anandrajak1
approved these changes
Aug 29, 2024
Do the comments have any impact on the code compiling? |
@shaynafinocchiaro no impact on the code compiling. |
shaynafinocchiaro
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update offline installer to ignore comments in the manifests.
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
./csi-offline-bundle.sh -c
Building image manifest file
Processing files in /root/workspacecsm/csi-unity/helm-charts/charts/csi-unity
Pulling and saving container images
dellemc/csi-unity:v2.11.0
dellemc/podmon:v1.10.0
registry.k8s.io/sig-storage/csi-attacher:v4.6.1
registry.k8s.io/sig-storage/csi-external-health-monitor-controller:v0.12.1
registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.10.1
registry.k8s.io/sig-storage/csi-provisioner:v5.0.1
registry.k8s.io/sig-storage/csi-resizer:v1.11.1
registry.k8s.io/sig-storage/csi-snapshotter:v8.0.1
Copying necessary files
/root/workspacecsm/csi-unity/helm-charts/charts/csi-unity
/root/workspacecsm/csi-unity/dell-csi-helm-installer
/root/workspacecsm/csi-unity/README.md
/root/workspacecsm/csi-unity/LICENSE
csi-unity-bundle-2.11.0/
csi-unity-bundle-2.11.0/helm-charts/
csi-unity-bundle-2.11.0/helm-charts/charts/
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/Chart.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/values.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/node.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/_helpers.tpl
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/csidriver.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/driver-config-params.yaml
csi-unity-bundle-2.11.0/helm-charts/charts/csi-unity/templates/controller.yaml
csi-unity-bundle-2.11.0/LICENSE
csi-unity-bundle-2.11.0/README.md
csi-unity-bundle-2.11.0/dell-csi-helm-installer/
csi-unity-bundle-2.11.0/dell-csi-helm-installer/common.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-csi-unity-v2.11.0.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-attacher-v4.6.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-resizer-v1.11.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-snapshotter-v8.0.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-node-driver-registrar-v2.10.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-external-health-monitor-controller-v0.12.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/dellemc-podmon-v1.10.0.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.tar/registry.k8s.io-sig-storage-csi-provisioner-v5.0.1.tar
csi-unity-bundle-2.11.0/dell-csi-helm-installer/csi-offline-bundle.md
csi-unity-bundle-2.11.0/dell-csi-helm-installer/.gitignore
csi-unity-bundle-2.11.0/dell-csi-helm-installer/verify-csi-unity.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/README.md
csi-unity-bundle-2.11.0/dell-csi-helm-installer/csi-install.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/images.manifest
csi-unity-bundle-2.11.0/dell-csi-helm-installer/verify.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/csi-uninstall.sh
csi-unity-bundle-2.11.0/dell-csi-helm-installer/csi-offline-bundle.sh
Offline bundle file is: /root/workspacecsm/csi-unity/csi-unity-bundle-2.11.0.tar.gz