Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OCP check to accept 4.11 in verify script #117

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

karthikk92
Copy link
Collaborator

Description

Update OCP check to accept 4.11 in verify script

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#491

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

automation results :
image

@@ -11,7 +11,7 @@
# verify-csi-unity method
function verify-csi-unity() {
verify_k8s_versions "1.21" "1.24"
verify_openshift_versions "4.9" "4.10"
verify_openshift_versions "4.9" "4.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthikk92 , Please change OCP min version to 4.10

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rensyct taken care

@karthikk92 karthikk92 force-pushed the update_ocp_version_to_4.11 branch from 418355e to bd004bb Compare October 3, 2022 12:55
panigs7
panigs7 previously approved these changes Oct 3, 2022
@rensyct
Copy link
Contributor

rensyct commented Oct 3, 2022

@karthikk92, please sign all your commits

@karthikk92
Copy link
Collaborator Author

@karthikk92, please sign all your commits

taken care @rensyct

panigs7
panigs7 previously approved these changes Oct 3, 2022
rensyct
rensyct previously approved these changes Oct 3, 2022
@karthikk92 karthikk92 dismissed stale reviews from rensyct and panigs7 via 37a598c October 3, 2022 13:47
@karthikk92 karthikk92 force-pushed the update_ocp_version_to_4.11 branch from ea0109f to 37a598c Compare October 3, 2022 13:47
@rensyct rensyct merged commit b271369 into main Oct 3, 2022
@mjsdell mjsdell deleted the update_ocp_version_to_4.11 branch October 17, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants