Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/volume swap issue #63

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Bugfix/volume swap issue #63

merged 4 commits into from
Mar 3, 2022

Conversation

francis-nijay
Copy link
Collaborator

Description

Added fix to filter FC and iSCSI targets based on appliance ID where the volume resides.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#198

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Fix tested on kuberenetes cluster with multi appliance array

Copy link
Contributor

@spriya-m spriya-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good.
Please fix the vetting error.

@francis-nijay
Copy link
Collaborator Author

Fix looks good. Please fix the vetting error.

fixed unit tests.

@harshitap26 harshitap26 merged commit 1a790e3 into main Mar 3, 2022
@harishp8889 harishp8889 deleted the bugfix/volume-swap-issue branch March 8, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants