Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFSv4 ACL support in CSI PowerStore #55

Merged
merged 11 commits into from
Feb 21, 2022
Merged

NFSv4 ACL support in CSI PowerStore #55

merged 11 commits into from
Feb 21, 2022

Conversation

spriya-m
Copy link
Contributor

@spriya-m spriya-m commented Feb 16, 2022

Description

Adding POSIX and NFSv4 ACL support in PowerStore CSI driver

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#191

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Verified that the valid POSIX mode bits or NFSv4 ACLs, whichever specified, is set on the mount directory.
  • Verified that the users with permissions only are able to access the NFS share from the pod
  • Verified that the precedence is honored -> Storage class > Secret > default

image

harishp8889
harishp8889 previously approved these changes Feb 16, 2022
Copy link
Collaborator

@harishp8889 harishp8889 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spriya-m Please attach the test results screen (HTML)

pkg/controller/controller.go Show resolved Hide resolved
pkg/node/acl.go Outdated Show resolved Hide resolved
pkg/node/stager.go Outdated Show resolved Hide resolved
samples/secret/secret.yaml Outdated Show resolved Hide resolved
harishp8889
harishp8889 previously approved these changes Feb 18, 2022
docker-files/Dockerfile.ubi.min Show resolved Hide resolved
helm/csi-powerstore/values.yaml Show resolved Hide resolved
helm/csi-powerstore/templates/controller.yaml Show resolved Hide resolved
pkg/controller/controller.go Show resolved Hide resolved
pkg/controller/controller.go Show resolved Hide resolved
pkg/node/acl.go Outdated Show resolved Hide resolved
samples/secret/secret.yaml Show resolved Hide resolved
samples/storageclass/powerstore-nfs.yaml Show resolved Hide resolved
bpjain2004
bpjain2004 previously approved these changes Feb 21, 2022
Copy link
Collaborator

@bpjain2004 bpjain2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment; otherwise looks good.

pkg/node/acl.go Outdated Show resolved Hide resolved
@spriya-m spriya-m dismissed stale reviews from bpjain2004 and harishp8889 via c3e36b8 February 21, 2022 12:18
bpjain2004
bpjain2004 previously approved these changes Feb 21, 2022
harishp8889
harishp8889 previously approved these changes Feb 21, 2022
bpjain2004
bpjain2004 previously approved these changes Feb 21, 2022
@spriya-m spriya-m dismissed stale reviews from bpjain2004 and harishp8889 via 49be4ad February 21, 2022 17:21
@francis-nijay francis-nijay merged commit e5e83e3 into main Feb 21, 2022
@spriya-m spriya-m deleted the feature/nfsv4-acl branch February 22, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants