-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFSv4 ACL support in CSI PowerStore #55
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spriya-m
requested review from
bpjain2004,
francis-nijay,
harishp8889,
harshitap26,
kumarp20,
prablr79 and
gilltaran
as code owners
February 16, 2022 11:42
harishp8889
previously approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spriya-m Please attach the test results screen (HTML)
harishp8889
requested changes
Feb 18, 2022
harishp8889
previously approved these changes
Feb 18, 2022
francis-nijay
requested changes
Feb 20, 2022
bpjain2004
previously approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment; otherwise looks good.
spriya-m
dismissed stale reviews from bpjain2004 and harishp8889
via
February 21, 2022 12:18
c3e36b8
bpjain2004
previously approved these changes
Feb 21, 2022
harishp8889
previously approved these changes
Feb 21, 2022
bpjain2004
previously approved these changes
Feb 21, 2022
spriya-m
dismissed stale reviews from bpjain2004 and harishp8889
via
February 21, 2022 17:21
49be4ad
bpjain2004
approved these changes
Feb 21, 2022
francis-nijay
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding POSIX and NFSv4 ACL support in PowerStore CSI driver
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration