Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side cars update #52

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Side cars update #52

merged 4 commits into from
Feb 17, 2022

Conversation

francis-nijay
Copy link
Collaborator

@francis-nijay francis-nijay commented Feb 9, 2022 •
edited
Loading

Description

Updated sidecars to the latest version.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#182

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on kuberenetes cluster

@harishp8889 harishp8889 self-assigned this Feb 11, 2022
harishp8889
harishp8889 previously approved these changes Feb 16, 2022
View reviewed changes
@harishp8889 harishp8889 removed their assignment Feb 16, 2022
@mjsdell
Copy link
Collaborator

mjsdell commented Feb 16, 2022

Any reason why this is still pending?

@prablr79 prablr79 merged commit a2c5062 into main Feb 17, 2022
@harishp8889 harishp8889 deleted the feature/csi-sidecars-update branch February 18, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spriya-m spriya-m spriya-m approved these changes

@prablr79 prablr79 prablr79 approved these changes

@harishp8889 harishp8889 harishp8889 left review comments

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@gilltaran gilltaran Awaiting requested review from gilltaran

@harshitap26 harshitap26 Awaiting requested review from harshitap26

@kumarp20 kumarp20 Awaiting requested review from kumarp20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@francis-nijay @mjsdell @harishp8889 @prablr79 @spriya-m