Update CODEOWNERS file

.github/CODEOWNERS

@@ -1,33 +1,17 @@
 # CODEOWNERS
 #
-# documentation for this file can be found at:
+# Documentation for this file can be found at:
 # https://help.github.com/en/articles/about-code-owners
 
 # These are the default owners for the code and will
 # be requested for review when someone opens a pull request.
-# order is alphabetical for easier maintenance.
+# Order is alphabetical for easier maintenance.
 #
+# Abhilash Muralidhara (abhi16394)
 # Adarsh Kumar Yadav (adarsh-dell)
 # Akshay Saini (AkshaySainiDell)
-# Aaron Tye (atye)
-# Boya Murthy (boyamurthy)
-# Bahubali Jain (bpjain2004)
-# Christian Coffield (ChristianAtDell, [email protected])
-# Utkarsh Dubey (delldubey)
-# Emily Kinuthia (EmilyKatdell)
-# Francis Nijay (francis-nijay)
-# Tarandeep Singh Gill (gilltaran)
-# Harish P (harishp8889)
-# Harshita Pandey (harshitap26)
-# Vinutha Kini (kenivi1)
-# Niranjan N (niranjan-n1)
-# Prasanna Muthukumaraswamy (prablr79)
-# Santhosh Lakshmanan (santhoshatdell, [email protected])
-# Satya Narayana (satyakonduri)
-# Yamunadevi Shanmugam (shanmydell)
-# Shayna Finocchiaro (shaynafinocchiaro)
-# Surya Prakash Gupta (suryagupta4)
-# Sushma T S (tssushma)
+# Don Khan (donatwork)
+# Santhosh Lakshmanan (santhoshatdell)
 
-# for all files:
-* @adarsh-dell @AkshaySainiDell @atye @boyamurthy @bpjain2004 @ChristianAtDell @delldubey @EmilyKatdell @francis-nijay @gilltaran @harishp8889 @harshitap26 @kenivi1 @niranjan-n1 @prablr79 @satyakonduri @santhoshhs10 @shanmydell @shaynafinocchiaro @suryagupta4 @tssushma
+# for all files
+* @abhi16394 @adarsh-dell @AkshaySainiDell @donatwork @santhoshatdell

pkg/controller/csi_extension_server.go

@@ -270,7 +270,7 @@ func (s *Service) checkIfNodeIsConnected(ctx context.Context, arrayID string, no
 		message = fmt.Sprintf("connectivity unknown for array %s to node %s due to %s", arrayID, nodeID, err)
 		log.Error(message)
 		rep.Messages = append(rep.Messages, message)
-		log.Errorf(err.Error())
+		log.Errorf("%s", err.Error())
 	}
 
 	if connected {

pkg/node/acl_test.go

@@ -19,7 +19,6 @@ package node
 import (
 	"context"
 	"errors"
-	"fmt"
 	"testing"
 
 	"github.com/dell/csi-powerstore/v2/mocks"
@@ -34,31 +33,31 @@ func TestPosixMode_Success(t *testing.T) {
 	isPosixMode := posixMode("0755")
 	expected := true
 	if isPosixMode != expected {
-		t.Errorf(fmt.Sprintf("expected: %v, actual: %v", expected, isPosixMode))
+		t.Errorf("expected: %v, actual: %v", expected, isPosixMode)
 	}
 }
 
 func TestPosixMode_Fail(t *testing.T) {
 	isPosixMode := posixMode("abcd")
 	expected := false
 	if isPosixMode != expected {
-		t.Errorf(fmt.Sprintf("expected: %v, actual: %v", expected, isPosixMode))
+		t.Errorf("expected: %v, actual: %v", expected, isPosixMode)
 	}
 }
 
 func TestNfsv4Acl_Success(t *testing.T) {
 	isNfsv4ACLs := nfsv4ACLs("A::OWNER@:RWX")
 	expected := true
 	if isNfsv4ACLs != expected {
-		t.Errorf(fmt.Sprintf("expected: %v, actual: %v", expected, isNfsv4ACLs))
+		t.Errorf("expected: %v, actual: %v", expected, isNfsv4ACLs)
 	}
 }
 
 func TestNfsv4Acl_Fail(t *testing.T) {
 	isNfsv4ACLs := nfsv4ACLs("abcd")
 	expected := false
 	if isNfsv4ACLs != expected {
-		t.Errorf(fmt.Sprintf("expected: %v, actual: %v", expected, isNfsv4ACLs))
+		t.Errorf("expected: %v, actual: %v", expected, isNfsv4ACLs)
 	}
 }
 
@@ -78,7 +77,7 @@ func TestNfsv4NasServer_Success(t *testing.T) {
 	isNFSv4Enabled := isNfsv4Enabled(context.Background(), clientMock, validNasName)
 	expected := true
 	if isNFSv4Enabled != expected {
-		t.Errorf(fmt.Sprintf("expected: %v, actual: %v", expected, isNFSv4Enabled))
+		t.Errorf("expected: %v, actual: %v", expected, isNFSv4Enabled)
 	}
 }
 
@@ -91,7 +90,7 @@ func TestNfsv4NasServer_Err_GetNASByName(t *testing.T) {
 	isNFSv4Enabled := isNfsv4Enabled(context.Background(), clientMock, validNasName)
 	expected := false
 	if isNFSv4Enabled != expected {
-		t.Errorf(fmt.Sprintf("expected: %v, actual: %v", expected, isNFSv4Enabled))
+		t.Errorf("expected: %v, actual: %v", expected, isNFSv4Enabled)
 	}
 }
 
@@ -111,7 +110,7 @@ func TestNfsv4NasServer_Err_GetNfsServer(t *testing.T) {
 	isNFSv4Enabled := isNfsv4Enabled(context.Background(), clientMock, validNasName)
 	expected := false
 	if isNFSv4Enabled != expected {
-		t.Errorf(fmt.Sprintf("expected: %v, actual: %v", expected, isNFSv4Enabled))
+		t.Errorf("expected: %v, actual: %v", expected, isNFSv4Enabled)
 	}
 }
 
@@ -131,7 +130,7 @@ func TestNfsv4NasServer_Fail(t *testing.T) {
 	isNFSv4Enabled := isNfsv4Enabled(context.Background(), clientMock, validNasName)
 	expected := false
 	if isNFSv4Enabled != expected {
-		t.Errorf(fmt.Sprintf("expected: %v, actual: %v", expected, isNFSv4Enabled))
+		t.Errorf("expected: %v, actual: %v", expected, isNFSv4Enabled)
 	}
 }
 
@@ -153,7 +152,7 @@ func TestValidateAndSetNfsACLs_Success_nfsv4Acls(t *testing.T) {
 	aclConfigured, err := validateAndSetACLs(context.Background(), nfsv4ACLsMock, validNasName, clientMock, "A::OWNER@:RWX", "dir2")
 
 	if err != nil || aclConfigured == false {
-		t.Errorf(fmt.Sprintf("expected: true, actual: %v err: %s", aclConfigured, err.Error()))
+		t.Errorf("expected: true, actual: %v err: %s", aclConfigured, err.Error())
 	}
 }
 
@@ -175,7 +174,7 @@ func TestValidateAndSetNfsACLs_Fail_InvalidAcls(t *testing.T) {
 	aclConfigured, err := validateAndSetACLs(context.Background(), nfsv4ACLsMock, validNasName, clientMock, "abcd", "dir1")
 
 	if err == nil || aclConfigured != false {
-		t.Errorf(fmt.Sprintf("expected: false, actual: %v err: %s", aclConfigured, err.Error()))
+		t.Errorf("expected: false, actual: %v err: %s", aclConfigured, err.Error())
 	}
 }
 
@@ -197,6 +196,6 @@ func TestValidateAndSetNfsACLs_Fail_GetNfsServerFail(t *testing.T) {
 	aclConfigured, err := validateAndSetACLs(context.Background(), nfsv4ACLsMock, validNasName, clientMock, "A::OWNER@:RWX", "dir1")
 
 	if err == nil || aclConfigured != false {
-		t.Errorf(fmt.Sprintf("expected: false, actual: %v err: %s", aclConfigured, err.Error()))
+		t.Errorf("expected: false, actual: %v err: %s", aclConfigured, err.Error())
 	}
 }

pkg/node/stager.go

@@ -193,9 +193,9 @@ func (n *NFSStager) Stage(ctx context.Context, req *csi.NodeStageVolumeRequest,
 	aclsConfigured := false
 	if acls != "" {
 		if posixMode(acls) {
-			perm, err := strconv.ParseUint(acls, 8, 64)
+			perm, err := strconv.ParseUint(acls, 8, 32)
 			if err == nil {
-				mode = os.FileMode(perm)
+				mode = os.FileMode(perm) // #nosec: G115 false positive
 			} else {
 				log.WithFields(logFields).Warn("can't parse file mode, invalid mode specified. Default mode permissions will be set.")
 			}