Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating go dependencies #329

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

boyamurthy
Copy link
Contributor

Updating go dependencies

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1280

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@adarsh-dell
Copy link
Contributor

Hi @boyamurthy ,

As you must be aware, PowerStore uses github.com/dell/csi-metadata-retriever. Please wait for the release of the metadata and update that module as well in go.mod before proceeding with the release of CSI-PowerStore.

Thanks!

@adarsh-dell
Copy link
Contributor

Hi @boyamurthy ,

As you must be aware, PowerStore uses github.com/dell/csi-metadata-retriever. Please wait for the release of the metadata and update that module as well in go.mod before proceeding with the release of CSI-PowerStore.

Thanks!

dell/csi-metadata-retriever#53

@boyamurthy
Copy link
Contributor Author

Hi @boyamurthy ,
As you must be aware, PowerStore uses github.com/dell/csi-metadata-retriever. Please wait for the release of the metadata and update that module as well in go.mod before proceeding with the release of CSI-PowerStore.
Thanks!

dell/csi-metadata-retriever#53

ok @adarsh-dell , will update this commit as well , thanks for the update.

@boyamurthy boyamurthy force-pushed the update_go_dependencies branch from cfccb79 to c10338d Compare May 28, 2024 11:02
@boyamurthy boyamurthy force-pushed the update_go_dependencies branch from c10338d to 8cab970 Compare May 28, 2024 11:05
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boyamurthy boyamurthy merged commit 707d688 into release-v2.10.1 May 28, 2024
1 check passed
@santhoshatdell santhoshatdell deleted the update_go_dependencies branch September 12, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants