Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating gofsutil #274

Merged
merged 1 commit into from
Sep 20, 2023
Merged

updating gofsutil #274

merged 1 commit into from
Sep 20, 2023

Conversation

adarsh-dell
Copy link
Contributor

@adarsh-dell adarsh-dell commented Sep 19, 2023

Description

Updated gofsutil module.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#885

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran cert-csi (9 suites) for NvmeFC protocol and 100% suites passed.
    image
    image

  • Ran cert-csi (9 suites) for FC protocol and 100% suites passed.
    image
    image

  • Ran cert-csi (9 suites) for iSCSI protocol and 100% suites passed.
    image
    image

  • Ran cert-csi (9 suites) for NFS protocol and 100% suites passed.
    image
    image

  • Ran cert-csi (9 suites) for Nvme/TCP protocol and 100% suites passed.
    image
    image

Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the tests that were executed along with the test results. Thank you.

@adarsh-dell adarsh-dell merged commit 8d5060f into main Sep 20, 2023
@shanmydell shanmydell deleted the latestGoFsUtil branch January 31, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants