Support for volume limits in CSI Powerstore #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alankar-verma
requested review from
adarsh-dell,
AkshaySainiDell,
bpjain2004,
ChristianAtDell,
francis-nijay,
harishp8889,
harshitap26,
niranjan-n1,
kumarp20,
prablr79,
santhoshatdell,
satyakonduri,
suryagupta4,
gilltaran and
kenivi1
as code owners
adarsh-dell
reviewed
Jul 25, 2023
adarsh-dell
reviewed
Jul 25, 2023
|
@alankar-verma Can you please run cert-csi once for iscsi & NFS protocol ? |
…incorporated review comments
Ran cert-csi, all the test suites succeeded |
adarsh-dell
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Looks good to me, thanks @alankar-verma for addressing all comments.
suryagupta4
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for volume limits feature in CSI Powerstore driver. The feature can be used either by setting :
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Set the node label "max-powerstore-volumes-per-node" to 2 for one of the worker node and then installed the driver with maxPowerstoreVolumesPerNode set to 1 in values.yaml
Node label set successfully:
Driver installed successfully:
Env variable X_CSI_POWERSTORE_MAX_VOLUMES_PER_NODE set successfully:
Tried to schedule multiple pods.
It allowed the creation of only 3 pods (2 + 1, "2" for one worker node because of the label "max-powerstore-volumes-per-node" set to "2" and "1" for other worker node because of the "maxPowerstoreVolumesPerNode" value set using values.yaml at the time of installation)