Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leeway to check tolerance #89

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

randeepdell
Copy link
Contributor

Description

It is possible for the tolerance and the timediff of connectivity check to be the same.
Adding a leeway of 2 sec for the same.

GitHub Issues

dell/csm#262

GitHub Issue #
dell/csm#262

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested that connectivity check is run successfully

Copy link
Collaborator

@nitesh3108 nitesh3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sakshi-dell Sakshi-dell merged commit 82d1b58 into main May 24, 2022
@Sakshi-dell Sakshi-dell deleted the podmon-improve-tolerance-check branch May 24, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants