Updated condition for IoInProgress call #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakshi-dell
requested review from
bpjain2004,
meggm,
nitesh3108,
prablr79,
randeepdell and
shefali-malhotra
as code owners
randeepdell
reviewed
May 18, 2022
| log.Error("Failed to get Isilon config with error ", err.Error()) | ||
| return nil, err | ||
| } | ||
| //Check for IOinProgress only when volumes IDs are present in the request as the field is required only in the latter case also to reduce number of calls to the API making it efficient |
There was a problem hiding this comment.
Would be more readable if this code in another function and called here.
randeepdell
approved these changes
May 18, 2022
meggm
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added condition to check for IOinProgress only when volumes IDs are present in the ValidateVolumeHostConnectivity request as the field is required only in the case when volumeID is present in the request, also to reduce the number of calls to the API making it efficient.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration